Fix optimistic data for distance request by dukenv0307 · Pull Request #32943 · Expensify/App

dukenv0307 · 2023-12-12T19:27:42Z

Details

Fix optimistic data for distance request

Fixed Issues

$ #32891
PROPOSAL: #32891 (comment)

Tests

Go offline
Create a distance request
Go to the expense report and verify that TBD display in preview
Click on the preview to open transaction thread report
Click on distance option verify that edit distance page is opened

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go offline
Create a distance request
Go to the expense report and verify that TBD display in preview
Click on the preview to open transaction thread report
Click on distance option verify that edit distance page is opened

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2023-12-13.at.02.11.14.mov

iOS: Native

Screen.Recording.2023-12-13.at.02.19.32.mov

iOS: mWeb Safari

Screen.Recording.2023-12-13.at.02.12.34.mov

MacOS: Chrome / Safari

web-1.mov

MacOS: Desktop

Screen.Recording.2023-12-13.at.02.24.40.mov

melvin-bot · 2023-12-12T19:28:22Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-12-12T19:29:31Z

@allroundexperts Has some problem with my android app, please help to test with this device.

allroundexperts · 2023-12-12T19:29:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-13.at.12.50.41.AM.mov

Android: mWeb Chrome

Screen.Recording.2023-12-13.at.12.49.23.AM.mov

iOS: Native

Screen.Recording.2023-12-13.at.12.45.48.AM.mov

iOS: mWeb Safari

Screen.Recording.2023-12-13.at.12.44.53.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-13.at.12.38.44.AM.mov

MacOS: Desktop

Screen.Recording.2023-12-13.at.12.42.25.AM.mov

allroundexperts · 2023-12-12T19:33:31Z

@dukenv0307 Lint is failing.

dukenv0307 · 2023-12-12T19:43:53Z

@allroundexperts Fixed.

tgolen · 2023-12-12T19:46:02Z

+    waitForCollectionCallback: true,
+    callback: (val) => {
+        if (!val) {
+            allTransactionDrafts = {};


Usually, the variable is initialized to {} and then this just becomes an early return. That way it's safe (from a code standpoint) to access allTransactionDrafts before it's fully initialized.

luacmartins · 2023-12-12T19:49:52Z

+    waitForCollectionCallback: true,
+    callback: (val) => {
+        if (!val) {
+            allTransactionDrafts = {};


dukenv0307 · 2023-12-12T19:53:31Z

    },
 });

+let allTransactionDrafts;


@tgolen So we will initialize it here, right?

@luacmartins Updated.

allroundexperts

Looks good!

tgolen

Perfect, thanks for that change.

OSBotify · 2023-12-12T20:28:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Fix optimistic data for distance request (cherry picked from commit 380e687)

…ing-32943-1 🍒 Cherry pick PR #32943 to staging 🍒

OSBotify · 2023-12-12T21:50:19Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.11-22 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-12T22:17:32Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.11-22 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-13T11:10:58Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.11-25 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dukenv0307 added 2 commits December 13, 2023 02:14

Fix optimistic data for distance request

5b323c4

merge main

f5b1b8c

dukenv0307 marked this pull request as ready for review December 12, 2023 19:28

dukenv0307 requested a review from a team as a code owner December 12, 2023 19:28

melvin-bot Bot requested review from allroundexperts and removed request for a team December 12, 2023 19:28

fix lint

41598b1

fix jest test

efb56ee

tgolen requested changes Dec 12, 2023

View reviewed changes

luacmartins requested changes Dec 12, 2023

View reviewed changes

dukenv0307 commented Dec 12, 2023

View reviewed changes

initialize allTransactionDrafts

291c768

allroundexperts approved these changes Dec 12, 2023

View reviewed changes

melvin-bot Bot requested a review from techievivek December 12, 2023 19:59

tgolen approved these changes Dec 12, 2023

View reviewed changes

luacmartins approved these changes Dec 12, 2023

View reviewed changes

luacmartins merged commit 380e687 into Expensify:main Dec 12, 2023

OSBotify pushed a commit that referenced this pull request Dec 12, 2023

Merge pull request #32943 from dukenv0307/fix/32891

be71e19

Fix optimistic data for distance request (cherry picked from commit 380e687)

os-botify Bot mentioned this pull request Dec 12, 2023

🍒 Cherry pick PR #32943 to staging 🍒 #32946

Merged

luacmartins added a commit that referenced this pull request Dec 12, 2023

Merge pull request #32946 from Expensify/luacmartins-cherry-pick-stag…

e361b77

…ing-32943-1 🍒 Cherry pick PR #32943 to staging 🍒

github-actions Bot mentioned this pull request Dec 12, 2023

Deploy Checklist: New Expensify 2023-12-11 #32794

Closed

81 tasks

melvin-bot Bot mentioned this pull request Dec 13, 2023

[HOLD for payment 2023-12-20] [$500] Distance- Request created offline does not show TBD in many areas and unable to open distance editor #32891

Closed

5 tasks

bernhardoj mentioned this pull request Dec 22, 2023

[$500] IOU - A "-" sign appears in front of the currency in the Distance IOU preview #33489

Closed

6 tasks

Uh oh!

Conversation

dukenv0307 commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 12, 2023

Uh oh!

dukenv0307 commented Dec 12, 2023

Uh oh!

allroundexperts commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Dec 12, 2023

Uh oh!

dukenv0307 commented Dec 12, 2023

Uh oh!

tgolen Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

luacmartins Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

luacmartins Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

luacmartins Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 12, 2023

Uh oh!

OSBotify commented Dec 12, 2023

Uh oh!

OSBotify commented Dec 12, 2023

Uh oh!

OSBotify commented Dec 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dukenv0307 commented Dec 12, 2023 •

edited

Loading

allroundexperts commented Dec 12, 2023 •

edited

Loading