[HOLD for payment 2023-12-20] [$500] Distance- Request created offline does not show TBD in many areas and unable to open distance editor

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.11-6
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to a workspace chat > + > Request money > Distance.
4. Create a distance request.
5. Click on the distance request preview twice to open the details page.

Expected Result:

• The header of expense details page, Amount row, and receipt show TBD.
• Distance row will remain as "Distance" and user is able to open distance editor when the distance request is created offline.

Actual Result:

The distance request created in offline mode behaves like a Scan request.

• The header of expense details page shwos "Receipt missing details".
• Receipt shows attachment thumbnail rather than the e-receipt.
• There is a red dot next to Amount row instead of TBD.
• Distance row is displayed as Merchant and user cannot open distance editor page when the request is created offline.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• [x ] iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309928_1702350289943.bandicam_2023-12-12_09-26-54-641__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01366049b9ef5743ae
• Upwork Job ID: 1734441817651273728
• Last Price Increase: 2023-12-12
• Automatic offers:
• dukenv0307 | Contributor | 28045822

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The distance request created in offline mode behaves like a Scan request.

What is the root cause of that problem?

In the past, we had an existing transaction to merge data if the request is distance request. But now we store it in transaction draft which makes distance request has wrong optimistic data and then it displays as scan request because it has receipt.

App/src/libs/actions/IOU.js

Line 641 in 4239252

const existingTransaction = existingTransactionID && TransactionUtils.getTransaction(existingTransactionID);

What changes do you think we should make in order to solve the problem?

We should get the transaction draft data and check if it's distance request we will merge data from this transaction to an optimistic transaction

1. In IOU.js Get transaction draft from Onyx

let allTransactionDrafts;
Onyx.connect({
    key: ONYXKEYS.COLLECTION.TRANSACTION_DRAFT,
    waitForCollectionCallback: true,
    callback: (val) => {
        if (!val) {
            allTransactionDrafts = {};
            return;
        }

        allTransactionDrafts = val;
    },
});

2. Change this line to

const existingTransaction =  allTransactionDrafts[`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${CONST.IOU.OPTIMISTIC_TRANSACTION_ID}`];

App/src/libs/actions/IOU.js

Line 641 in 4239252

const existingTransaction = existingTransactionID && TransactionUtils.getTransaction(existingTransactionID);

3. Change this condition to and when merging we will

if (existingTransaction.iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE) {
   optimisticTransaction = {
        ...optimisticTransaction,
        ...existingTransaction,
        transactionID: optimisticTransaction.transactionID
    };
}

App/src/libs/actions/IOU.js

Line 642 in 4239252

if (existingTransaction) {

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-12-12.at.12.08.37.mov

[techievivek]

@dukenv0307 Is this linked to a recent change? Do you mind linking the PR? Thanks