Fix Not Found view briefly appears on workspace members and invite pages

[kowczarz]

Details

Fixed Issues

$ #19236
PROPOSAL: #19236(COMMENT)

Tests

1. Open invite members to organisation on web app
2. Copy the url form address bar (e.g. http://localhost:8080/workspace/xxxxx/invite)
3. Open desktop app (logout if already logged in)
4. Paste url in new tab and open desktop app from popup (replace http with new-expensify)

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

1. Open invite members to organisation on web app
2. Copy the url form address bar (e.g. http://localhost:8080/workspace/xxxxx/invite)
3. Open desktop app (logout if already logged in)
4. Paste url in new tab and open desktop app from popup (replace http with new-expensify)

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • [x ] A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-23.at.11.56.53.mov

web.members.mov

Mobile Web - Chrome

android.web.members.mov

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-23.at.14.38.43.mp4

ios.web.members.mp4

Desktop

Screen.Recording.2023-06-23.at.14.36.24.mov

desktop.members_H.265.mp4

iOS

Untitled.mp4

Android

Screen.Recording.2023-06-27.at.14.59.18.mov

android.members.mov

[melvin-bot]

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[aimane-chnaif]

@kowczarz is this ready for review?

[kowczarz]

@aimane-chnaif yes

[jasperhuangg]

@aimane-chnaif Can you help out with this review?

[aimane-chnaif]

@aimane-chnaif Can you help out with this review?

yes

[kowczarz]

@aimane-chnaif any update?

[aimane-chnaif]

Workspace invite page looks good.
As GH title says, let's fix workspace members page as well.

[aimane-chnaif]

One more thing to consider:

What content will show if personalDetails is ready but still loading report data?

[kowczarz]

@aimane-chnaif I applied requested changes.

[aimane-chnaif]

members.mov

@kowczarz let's add skeleton in Members page.
As you see, Member not found. To invite a new member to the workspace, please use the Invite button above. message shows while loading.

These conditions are to check if members list is not loaded yet

• _.isEmpty(props.policyMembers)
• !OptionsListUtils.isPersonalDetailsReady(props.personalDetails)

[aimane-chnaif]

I have concern about skeleton design on Workspace members page, as it's a bit different from other option list item.
There's a checkbox which is unique. Should we consider this as well or just common skeleton view is fine?
cc: @amyevans @shawnborton

[amyevans]

I have concern about skeleton design on Workspace members page, as it's a bit different from other option list item.
There's a checkbox which is unique. Should we consider this as well or just common skeleton view is fine?

Hmm. My initial reaction is that the existing skeleton is close enough, but I definitely defer to @shawnborton's opinion if he disagrees 😄

[shawnborton]

Yeah I also agree that the existing skeleton is close enough.

[kowczarz]

@aimane-chnaif done.

[aimane-chnaif]

@kowczarz please add workspace members page to QA Steps and videos

[jasperhuangg]

@kowczarz Please address @aimane-chnaif's comment here. Let's get this merged asap since it looks like it keeps conflicting!

[kowczarz]

@aimane-chnaif fixed, I had overwritten my git config and I didn't spot it.

[aimane-chnaif]

Offline behavior on members page before loading members list

I am not sure which one is expected to show:

1. Member not found (before fix)

2. skeleton (after fix)

@amyevans any suggestion?

[amyevans]

Hmm I could see a case made for either, but I think the skeleton is fine, I'd consider it a slightly more accurate representation

[aimane-chnaif]

LGTM. @amyevans all yours

[melvin-bot]

🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #25587.

[jasperhuangg]

lgtm!

[amyevans]

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅