Not Found view briefly appears on workspace members and invite pages

[amyevans]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

This is a follow up issue from #17349 (comment)

Action Performed:

Open workspace members or invite page from deep link

Expected Result:

No flash of "Not Found" view

Actual Result:

Flash of "Not Found" view

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

invite.mov

members.mov

Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ab8e5ee8dfc45ea
• Upwork Job ID: 1669436508157517824
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[amyevans]

@jczekalski please comment on the issue so I can assign you

[dukenv0307]

This issue is fixed by this PR: #18967

[aimane-chnaif]

This issue is fixed by this PR: #18967

That doesn't fix the issue completely. We should show skeleton instead of full screen loading

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Open workspace members or invite page from deep link and have flash of "Not Found" view

What is the root cause of that problem?

In here

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 151 in b7391bc

shouldShow={_.isEmpty(this.props.policy)}

We're showing Not Found page if the this.props.policy is empty. When we navigate to the Workspace Settings page by link and login, the policy wasn't loaded yet (using the OpenApp API), so it shows Not Found briefly until the policy is loaded.

What changes do you think we should make in order to solve the problem?

Base on @aimane-chnaif's comment, we need to build WorkspaceInvitePageSkeletonView and WorkspaceMembersPageSkeletonView and check if the policy is empty and the report is loading, if yes that means the policy is not initially loaded yet, so we show a WorkspaceInvitePageSkeletonView or WorkspaceMembersPageSkeletonView

if (this.props.isLoadingReportData && _.isEmpty(this.props.policy)) {
    return <WorkspaceMembersPageSkeletonView />;
}

if (this.props.isLoadingReportData && _.isEmpty(this.props.policy)) {
    return <WorkspaceInvitePageSkeletonView />;
}

What alternative solutions did you explore? (Optional)

NA

[jczekalski]

I'm an expert contributor from Software Mansion and I'd like to investigate this issue (@amyevans).

[melvin-bot]

@amyevans, @mallenexpensify, @jczekalski, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!