Skip to content

Remove flag that is causing iOS to fail to upload #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 2 commits into from
Mar 22, 2021
Merged

Remove flag that is causing iOS to fail to upload #1984

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd0e382
Remove flag that is causing iOS to fail to upload
AndrewGable Mar 22, 2021
f14370f
Add comment and default value
AndrewGable Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ platform :ios do
upload_to_testflight(
api_key_path: "./ios/ios-fastlane-json-key.json",
distribute_external: true,
reject_build_waiting_for_review: true,
Comment thread
AndrewGable marked this conversation as resolved.
# TODO: Set reject_build_waiting_for_review back to true when https://github.com/fastlane/fastlane/issues/18408 is resolved
# See: https://github.com/Expensify/Expensify.cash/pull/1984 for more information
reject_build_waiting_for_review: false,
changelog: "Thank you for beta testing Expensify.cash, this version includes bug fixes and improvements.",
groups: ["Beta"],
demo_account_required: true,
Expand Down