Skip to content

Remove flag that is causing iOS to fail to upload#1984

Merged
roryabraham merged 2 commits into
masterfrom
andrew-ios-review
Mar 22, 2021
Merged

Remove flag that is causing iOS to fail to upload#1984
roryabraham merged 2 commits into
masterfrom
andrew-ios-review

Conversation

@AndrewGable

Copy link
Copy Markdown
Contributor

Details

The reject_build_waiting_for_review flag is throwing errors on all iOS builds. We've created an issue with Fastlane here: fastlane/fastlane#18408 but we are unsure when they will be able to look into the issue, so let's remove that flag for now.

Fixed Issues

Fixes broken iOS workflows

Tests

  1. Merge this PR
  2. Verify iOS builds and deploys correctly

@AndrewGable AndrewGable requested a review from roryabraham March 22, 2021 18:08
@AndrewGable AndrewGable self-assigned this Mar 22, 2021
@AndrewGable AndrewGable requested a review from a team as a code owner March 22, 2021 18:08
@botify botify requested review from NikkiWines and removed request for a team March 22, 2021 18:08
Comment thread fastlane/Fastfile
@AndrewGable AndrewGable requested a review from roryabraham March 22, 2021 18:16

@roryabraham roryabraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a go!

@roryabraham roryabraham merged commit ace7615 into master Mar 22, 2021
@roryabraham roryabraham deleted the andrew-ios-review branch March 22, 2021 18:52
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 22, 2021
@roryabraham

Copy link
Copy Markdown
Contributor

Tracking here to see if this resolves our iOS deploy issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants