Skip to content

Fix - Pressing enter twice on selecting currency from search closes the send money/request money option #18265 #18853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-mechler merged 6 commits into from
May 15, 2023
Merged

Fix - Pressing enter twice on selecting currency from search closes the send money/request money option #18265 #18853

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
00c0523
Issue18265
AmjedNazzal May 12, 2023
6fc32bd
add promise to debounce
AmjedNazzal May 12, 2023
3f4eafa
Changed variable name
AmjedNazzal May 12, 2023
3787a3e
Merge branch 'Expensify:main' into Issue18265
AmjedNazzal May 12, 2023
0f222ef
Merge branch 'Expensify:main' into Issue18265
AmjedNazzal May 13, 2023
f624081
logic adjustment
AmjedNazzal May 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/components/OptionsSelector/BaseOptionsSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class BaseOptionsSelector extends Component {
this.state = {
allOptions,
focusedIndex,
shouldDisableRowSelection: false,
};
}

Expand All @@ -59,8 +60,16 @@ class BaseOptionsSelector extends Component {
if (!focusedOption) {
return;
}

this.selectRow(focusedOption);
if (this.props.canSelectMultipleOptions) {
this.selectRow(focusedOption);
Comment thread
AmjedNazzal marked this conversation as resolved.
} else if (!this.state.shouldDisableRowSelection) {
this.setState({shouldDisableRowSelection: true});
let result = this.selectRow(focusedOption);
if (!(result instanceof Promise)) {
result = Promise.resolve();
}
setTimeout(() => result.finally(() => this.setState({shouldDisableRowSelection: false})), 500);
}
},
enterConfig.descriptionKey,
enterConfig.modifiers,
Expand Down