Migrate Forms into NewContactMethodPage by dhairyasenjaliya · Pull Request #18223 · Expensify/App

dhairyasenjaliya · 2023-05-01T13:06:42Z

Details

We are adding validation to the new Contact page for checking if the user has inputted the contact method which is already an existing contact then we are displaying the error

Fixed Issues

$ #17997
PROPOSAL: #17997 (comment)

Tests

Go to Settings > Profile > Contact Method
Click on the New contact method button
Enter your current email address in the email field
Click on Add
Verify that the error display The Entered Contact Method already exists.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go to Settings > Profile > Contact Method
Click on the New contact method button
Enter your current email address in the email field
Click on Add
Verify that the error display The Entered Contact Method already exists.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

MelvinBot · 2023-05-01T13:06:48Z

@cristipaval @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dhairyasenjaliya · 2023-05-01T13:49:24Z

hey @mollfpr @cristipaval We are adding a few validation texts here do we need someone to translate for us should I ask in Slack?

en.js ->

es.js ->

mollfpr

@dhairyasenjaliya Thanks for the quick PR!

A couple of request changes, and for the email/phone input, we should add shouldSaveDraft.

Saving draft values is highly desirable, and we should always try to save draft values. Additionally, we should clear draft data once the form is successfully submitted by calling Onyx.set(ONYXKEY.FORM_ID, null) in the onSubmit callback passed to Form.

For the copy, we can get it faster from the Slack channel.

mollfpr · 2023-05-02T11:18:58Z

+                        inputID="phoneOrEmail"
                        autoCapitalize="none"
                        returnKeyType={Permissions.canUsePasswordlessLogins(props.betas) ? 'done' : 'next'}
+                        autoFocus


I think it's better to use the previous implementation to focus on the input with onTransitionEnd. With this I found it's a bit weird transition with iOS and on Android sometimes the keyboard is not open even the input is focused.

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-05-02.at.18.14.28.mp4

Android

Screen.Recording.2023-05-02.at.18.15.45.mov

alright let me quick check this one to use onEntryTransitionEnd

@mollfpr not sure why but I'm not getting ref event on <TextInput>

dhairyasenjaliya · 2023-05-02T11:26:56Z

@dhairyasenjaliya Thanks for the quick PR!

A couple of request changes, and for the email/phone input, we should add shouldSaveDraft.

Saving draft values is highly desirable, and we should always try to save draft values. Additionally, we should clear draft data once the form is successfully submitted by calling Onyx.set(ONYXKEY.FORM_ID, null) in the onSubmit callback passed to Form.

For the copy, we can get it faster from the Slack channel.

hm, do you suggest adding shouldSaveDraft to newContact form?

mollfpr · 2023-05-02T11:35:14Z

hm, do you suggest adding shouldSaveDraft to newContact form?

Yes!

dhairyasenjaliya · 2023-05-02T13:38:25Z

@dhairyasenjaliya Thanks for the quick PR!
A couple of request changes, and for the email/phone input, we should add shouldSaveDraft.

Saving draft values is highly desirable, and we should always try to save draft values. Additionally, we should clear draft data once the form is successfully submitted by calling Onyx.set(ONYXKEY.FORM_ID, null) in the onSubmit callback passed to Form.

For the copy, we can get it faster from the Slack channel.

hm, do you suggest adding shouldSaveDraft to newContact form?

@mollfpr also where do we need to clear this shouldSaveDraft ?

mollfpr · 2023-05-02T14:17:55Z

@dhairyasenjaliya Could you check if the old input value is not cleared after the form submit success? Also, could you resolve that conflict? Thanks!

dhairyasenjaliya · 2023-05-02T18:17:38Z

@mollfpr all query resolve let me know if any further improvement required :)

mollfpr · 2023-05-03T02:23:31Z

@dhairyasenjaliya Thanks!

Another conflict need to solved 😅

dhairyasenjaliya · 2023-05-03T03:57:33Z

@mollfpr oop lots of things going on this page 😄 btw Im waiting for translation text do we tag someone ?

mollfpr · 2023-05-03T04:00:11Z

@dhairyasenjaliya I don't know too 😅 @cristipaval can add the label Waiting for Copy, and someone will be pulled to confirm the copy.

dhairyasenjaliya · 2023-05-03T04:04:22Z

@mollfpr Yeah, we can do that also conflict is resolved & I think PR is ready for merge just waiting for the translation text

cristipaval · 2023-05-08T18:45:58Z

@dhairyasenjaliya Could you please merge the latest main?

dhairyasenjaliya · 2023-05-08T18:51:14Z

@cristipaval Sure btw we are just waiting for translation messages

dhairyasenjaliya · 2023-05-08T19:06:28Z

@cristipaval conflict resolved do we bump anyone about translating messages? this is only left here

dhairyasenjaliya · 2023-05-10T19:45:17Z

@mollfpr @cristipaval all translation messages updated as per suggestion and conflict resolved we should merge this

dhairyasenjaliya · 2023-05-11T15:46:46Z

Bump @mollfpr

mollfpr · 2023-05-11T17:22:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

18223.Web.mov

Mobile Web - Chrome

18223.mWeb.Chrome.mov

Mobile Web - Safari

18223.mWeb.Safari.mp4

Desktop

18223.Desktop.mov

iOS

18223.iOS.mp4

Android

Screen.Recording.2023-05-12.at.14.44.31.mov

mollfpr · 2023-05-11T17:34:25Z

I'm running out of time to record the test. I'll try to finish it in the morning.

dhairyasenjaliya · 2023-05-12T07:21:14Z

@mollfpr When you get a chance let's complete this before fixing another conflict 😄

mollfpr · 2023-05-12T07:41:51Z

Sorry for the delay @dhairyasenjaliya! The code looks good to me, I just need a record for the Android.

Could you update the test to include the expected is? Like add one more point Verify that the error display The Entered Contact Method already exists.

mollfpr

LGTM 🚀

dhairyasenjaliya · 2023-05-12T07:56:49Z

@mollfpr added

mollfpr · 2023-05-12T08:10:35Z

Completed the checklist! All yours @cristipaval

OSBotify · 2023-05-12T13:00:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-15T09:19:47Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-17T00:19:37Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2023-07-05T12:44:24Z


-        return (Permissions.canUsePasswordlessLogins(props.betas) || password) && (Str.isValidEmail(login) || parsePhoneNumber(phoneLogin).possible);
-    }, [login, password, props.betas]);
+    const validate = (values) => {


Coming from #20610:
This was overlooked while doing form refactor.
validate is re-triggered when form is submitted and it caused a small regression: email already exist message appears for a second when go to previous screen.
More details about the root cause: #20610 (comment)

useCallback and original dependencies were added in https://github.com/Expensify/App/pull/17472/files#diff-fe6782071280d20a06400ddd9435c11ea1961b6d8601c9acdc1e42257ad52348R84 and we should have considered this while introducing form and removing useCallback.

fedirjh · 2023-08-02T18:28:59Z

+    const validateNumber = (values) => {
+        const parsedPhoneNumber = parsePhoneNumber(values);
+
+        if (parsedPhoneNumber.possible) {


This line caused a regression in #22819, parsePhoneNumber will treat 1234567890@ as a valid phone number. more context #22819 (comment)

Added Form into NewContactMethodPage

7bc8682

dhairyasenjaliya requested a review from a team as a code owner May 1, 2023 13:06

melvin-bot Bot requested review from cristipaval and mollfpr and removed request for a team May 1, 2023 13:06

dhairyasenjaliya added 2 commits May 1, 2023 18:53

EsLint fixes

461024a

EsLint cleanup

716a7d1

Added validation to prevent duplicate contact if added as capital

9270363

mollfpr requested changes May 2, 2023

View reviewed changes

Comment thread src/ONYXKEYS.js Outdated

Comment thread src/pages/settings/Profile/Contacts/NewContactMethodPage.js Outdated

Comment thread src/pages/settings/Profile/Contacts/NewContactMethodPage.js

mollfpr reviewed May 2, 2023

View reviewed changes

Key name fixes and import fixes

3658c17

mollfpr reviewed May 2, 2023

View reviewed changes

Comment thread src/pages/settings/Profile/Contacts/NewContactMethodPage.js Outdated

mollfpr reviewed May 2, 2023

View reviewed changes

Comment thread src/pages/settings/Profile/Contacts/NewContactMethodPage.js

dhairyasenjaliya added 2 commits May 2, 2023 17:39

use of ErrorUtils in form validation

8620fa6

Added onEntryTransitionEnd

e3a0989

dhairyasenjaliya added 2 commits May 2, 2023 22:49

Fixed Conflict

9c397e0

Clear draft onyx on success

8fb5445

Fix conflict:

9b294f6

Conflict resolved

13eeb80

Conflict fix

0764684

dhairyasenjaliya added 4 commits May 11, 2023 00:41

Conflict fix

e3eea39

Translation message added

a9002d4

Prettier Fix

2ebf61c

Test-commit

ac18adf

cristipaval requested a review from mollfpr May 11, 2023 09:54

mollfpr approved these changes May 12, 2023

View reviewed changes

cristipaval approved these changes May 12, 2023

View reviewed changes

cristipaval merged commit 2376b77 into Expensify:main May 12, 2023

OSBotify mentioned this pull request May 15, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

melvin-bot Bot mentioned this pull request May 16, 2023

[HOLD for payment 2023-05-23] [$1000] Not getting any error while trying to add the current default method as a new contact method. #17997

Closed

6 tasks

aimane-chnaif reviewed Jul 5, 2023

View reviewed changes

aimane-chnaif mentioned this pull request Jul 5, 2023

[HOLD for payment 2023-07-05] [$1000] Contact Method - Email already exist message appears for a second on click of add button #20610

Closed

6 tasks

mananjadhav mentioned this pull request Jul 10, 2023

[HOLD for payment 2023-07-06] [$1000] Error not displayed for invalid phone number in New Contact Method section #21247

Closed

6 tasks

fedirjh reviewed Aug 2, 2023

View reviewed changes

fedirjh mentioned this pull request Aug 2, 2023

[HOLD for payment 2023-08-01] [$1000] Web - Multiple errors are displayed on add new contact method #22819

Closed

6 tasks

Uh oh!

Conversation

dhairyasenjaliya commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented May 1, 2023

Uh oh!

dhairyasenjaliya commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mollfpr May 2, 2023

Choose a reason for hiding this comment

Uh oh!

dhairyasenjaliya May 2, 2023

Choose a reason for hiding this comment

Uh oh!

dhairyasenjaliya May 2, 2023

Choose a reason for hiding this comment

Uh oh!

dhairyasenjaliya commented May 2, 2023

Uh oh!

Uh oh!

Uh oh!

mollfpr commented May 2, 2023

Uh oh!

dhairyasenjaliya commented May 2, 2023

Uh oh!

mollfpr commented May 2, 2023

Uh oh!

dhairyasenjaliya commented May 2, 2023

Uh oh!

mollfpr commented May 3, 2023

Uh oh!

dhairyasenjaliya commented May 3, 2023

Uh oh!

mollfpr commented May 3, 2023

Uh oh!

dhairyasenjaliya commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cristipaval commented May 8, 2023

Uh oh!

dhairyasenjaliya commented May 8, 2023

Uh oh!

dhairyasenjaliya commented May 8, 2023

Uh oh!

dhairyasenjaliya commented May 10, 2023

Uh oh!

dhairyasenjaliya commented May 11, 2023

Uh oh!

mollfpr commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr commented May 11, 2023

Uh oh!

dhairyasenjaliya commented May 12, 2023

Uh oh!

mollfpr commented May 12, 2023

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

dhairyasenjaliya commented May 12, 2023

Uh oh!

mollfpr commented May 12, 2023

dhairyasenjaliya commented May 1, 2023 •

edited

Loading

dhairyasenjaliya commented May 1, 2023 •

edited

Loading

dhairyasenjaliya commented May 3, 2023 •

edited

Loading

mollfpr commented May 11, 2023 •

edited

Loading