[HOLD for payment 2023-08-01] [$1000] Web - Multiple errors are displayed on add new contact method

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: logged in user should at verified phone number contact method

1. Open the app
2. Open settings
3. Open profile
4. Open Contact method
5. Click on New contact method
6. Write phone number which is already existing for the user and click on Add
7. Write @ after it and observe that app now displays 2 contradicting errors below the field

Expected Result:

App should only display one error at a time while adding new contact method

Actual Result:

App displays 2 error methods at a time when we add phone number which is already a contact of user, click on add and write @ after the number

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

multiple.errors.on.new.contact.add.mp4

Recording.3600.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689176460712529

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01854db3eb3bfd067b
• Upwork Job ID: 1679996083560108032
• Last Price Increase: 2023-07-14

[GItGudRatio]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Two errors show up simultaneously on the Default Contact page when the input is {default contact number}@.

What is the root cause of that problem?

Let's assume my mobile number is 1234567890.

When I enter the input 1234567890@, the library awesome-phonenumber interprets the number without the added @ and since the leftover is a valid number, the property parsePhoneNumber(phoneLogin).possible is true.

However, the validation on Str.isValidPhone(phoneLogin.slice(0)) catches the incorrect input properly and returns false. Since the condition equates to !(false || false), which is equal to true, the Invalid Contact Method error is shown, which is actually the correct behaviour.

Now, to validate the default contact method, we use the validateNumber function, which just checks for parsePhoneNumber(phoneLogin).possible, which is possible even when the input has an @.

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Lines 97 to 103 in 8923cb0

	if (!_.isEmpty(values.phoneOrEmail) && !((parsePhoneNumber(phoneLogin).possible && Str.isValidPhone(phoneLogin.slice(0))) || Str.isValidEmail(values.phoneOrEmail))) {
	ErrorUtils.addErrorMessage(errors, 'phoneOrEmail', 'contacts.genericFailureMessages.invalidContactMethod');
	}
	if (!_.isEmpty(values.phoneOrEmail) && lodashGet(props.loginList, validateIfnumber || values.phoneOrEmail.toLowerCase())) {
	ErrorUtils.addErrorMessage(errors, 'phoneOrEmail', 'contacts.genericFailureMessages.enteredMethodIsAlreadySubmited');
	}

What changes do you think we should make in order to solve the problem?

To fix this issue, in addition to verifying if the number is possible, we should also verify if the entered input is syntatically correct by using Str.isValidPhone(values.slice(0)) in the validateNumber function.

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Lines 65 to 70 in 8923cb0

	const validateNumber = (values) => {
	const parsedPhoneNumber = parsePhoneNumber(values);
	if (parsedPhoneNumber.possible) {
	return parsedPhoneNumber.number.e164 + CONST.SMS.DOMAIN;
	}

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Multiple errors are displayed on add new contact method.

What is the root cause of that problem?

When adding new contact method, the errors are generated as follow.

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js

Lines 91 to 109 in 138a41c

	const errors = {};
	if (_.isEmpty(values.phoneOrEmail)) {
	ErrorUtils.addErrorMessage(errors, 'phoneOrEmail', 'contacts.genericFailureMessages.contactMethodRequired');
	}
	if (!_.isEmpty(values.phoneOrEmail) && !((parsePhoneNumber(phoneLogin).possible && Str.isValidPhone(phoneLogin.slice(0))) || Str.isValidEmail(values.phoneOrEmail))) {
	ErrorUtils.addErrorMessage(errors, 'phoneOrEmail', 'contacts.genericFailureMessages.invalidContactMethod');
	}
	if (!_.isEmpty(values.phoneOrEmail) && lodashGet(props.loginList, validateIfnumber || values.phoneOrEmail.toLowerCase())) {
	ErrorUtils.addErrorMessage(errors, 'phoneOrEmail', 'contacts.genericFailureMessages.enteredMethodIsAlreadySubmited');
	}
	if (!Permissions.canUsePasswordlessLogins(props.betas) && _.isEmpty(values.password)) {
	errors.password = 'contacts.genericFailureMessages.passwordRequired';
	}
	return errors;

Because we add @ after phone number, it is not a valid format, so the first invalidContactMethod error message will be added to errors.
And when parsing phone number, awesome-phonenumber remove @ and store valid phone number to number.e164.
Therefore, generated validateIfNumber is same as existing contact method, and then the second invalidContactMethod error message will be added to errors.
So the two error message will be displayed.

What changes do you think we should make in order to solve the problem?

We can return errors in every if clause in order to display only one error message.

    if (_.isEmpty(values.phoneOrEmail)) {
        ErrorUtils.addErrorMessage(errors, 'phoneOrEmail', 'contacts.genericFailureMessages.contactMethodRequired');
+       return errors;
    }

    if (!_.isEmpty(values.phoneOrEmail) && !((parsePhoneNumber(phoneLogin).possible && Str.isValidPhone(phoneLogin.slice(0))) || Str.isValidEmail(values.phoneOrEmail))) {
        ErrorUtils.addErrorMessage(errors, 'phoneOrEmail', 'contacts.genericFailureMessages.invalidContactMethod');
+       return errors;
    }

    if (!_.isEmpty(values.phoneOrEmail) && lodashGet(props.loginList, validateIfnumber || values.phoneOrEmail.toLowerCase())) {
        ErrorUtils.addErrorMessage(errors, 'phoneOrEmail', 'contacts.genericFailureMessages.enteredMethodIsAlreadySubmited');
+       return errors;
    }

    if (!Permissions.canUsePasswordlessLogins(props.betas) && _.isEmpty(values.password)) {
        errors.password = 'contacts.genericFailureMessages.passwordRequired';
    }

    return errors;

What alternative solutions did you explore? (Optional)

None.

[mallenexpensify]

Was able to reproduce. Only happens for phone numbers, not emails.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01854db3eb3bfd067b

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)