Skip to content

Make AsActionResult virtual#289

Closed
LockTar wants to merge 1 commit intoEventuous:devfrom
LockTar:f/virtual-asactionresult
Closed

Make AsActionResult virtual#289
LockTar wants to merge 1 commit intoEventuous:devfrom
LockTar:f/virtual-asactionresult

Conversation

@LockTar
Copy link
Copy Markdown
Contributor

@LockTar LockTar commented Nov 8, 2023

Make AsActionResult virtual. This PR can be ignored if #288 is approved.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 8, 2023

Test Results

  32 files   -   16    32 suites   - 16   9m 59s ⏱️ -40s
132 tests  -     2  132 ✔️  -     2  0 💤 ±0  0 ±0 
260 runs   - 130  260 ✔️  - 130  0 💤 ±0  0 ±0 

Results for commit 1269bc8. ± Comparison against base commit a66fb59.

This pull request removes 6 and adds 4 tests. Note that renamed tests count towards both.
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:47, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:49, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 10/12/2023 11:55:52, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:19, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/08/2023 14:54:21, Valid = True, LogContext =  })

@LockTar LockTar marked this pull request as ready for review November 8, 2023 15:13
@LockTar LockTar deleted the f/virtual-asactionresult branch November 16, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants