Return bad request as ValidationProblemDetails

[LockTar]

• Return ValidationProblemDetails as result for 400 errors
• Implement AsActionResult the same way as in ResultExtensions
• Make AsActionResult protected virtual so you can override the implementation.

[github-actions]

Test Results

  32 files   -   16    32 suites   - 16   9m 27s ⏱️ -56s
130 tests  -     4  129 ✔️  -     5  0 💤 ±0  1 ❌ +1 
260 runs   - 130  259 ✔️  - 131  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 07ab9e3. ± Comparison against base commit 5058222.

This pull request removes 6 and adds 2 tests. Note that renamed tests count towards both.

Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:14, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:16, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:18, Valid = True, LogContext =  })

Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 4, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  })
Eventuous.Tests.Subscriptions.SequenceTests ‑ ShouldReturnFirstBefore(sequence: [CommitPosition { Position = 0, Sequence = 1, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 6, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  }, CommitPosition { Position = 0, Sequence = 8, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  }], expected: CommitPosition { Position = 0, Sequence = 2, Timestamp = 11/15/2023 15:32:52, Valid = True, LogContext =  })

♻️ This comment has been updated with latest results.