Skip to content

release: v3.4.0-rc.1 – develop → staging#866

Merged
nevil-mathew merged 17 commits into
stagingfrom
develop
Mar 5, 2026
Merged

release: v3.4.0-rc.1 – develop → staging#866
nevil-mathew merged 17 commits into
stagingfrom
develop

Conversation

@nevil-mathew

@nevil-mathew nevil-mathew commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added SERVICE_NAME environment variable for service configuration.
  • Chores

    • Version updated to 3.3.24.
    • Updated health check library dependency.
    • Health check responses now include actual package version information.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Nov 27, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1e9879d7-50ed-4b91-8ab8-917d7a412a73

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The PR adds a SERVICE_NAME environment variable for health checks, updates health check implementation to dynamically read the package.json version instead of using a hard-coded value, removes version fields from health check responses, and bumps package version from 1.0.0 to 3.3.24 with updated dependencies.

Changes

Cohort / File(s) Change Summary
Environment Configuration
src/.env.sample, src/envVariables.js
Added SERVICE_NAME environment variable with default value 'UserService' and optional flag. Includes comment for health check service naming.
Health Check Implementation
src/health-checks/health-check.js, src/health-checks/health.config.js
Removed hard-coded version field from configuration and responses. Updated health-check.js to read version from package.json and pass it to healthCheckHandler.
Dependencies
src/package.json
Bumped package version from 1.0.0 to 3.3.24. Updated elevate-services-health-check dependency from ^0.0.6 to ^0.0.9.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Version handling change: Verify that dynamic version reading from package.json integrates correctly with the updated elevate-services-health-check dependency (^0.0.9).
  • Dependency compatibility: Confirm that the health check implementation remains compatible with the new dependency version and that response payload changes align with expected formats.
  • SERVICE_NAME propagation: Ensure the new SERVICE_NAME environment variable is properly utilized throughout the health check flow.

Possibly related PRs

  • kafka-fix #862: Adds identical SERVICE_NAME environment variable configuration across the codebase, indicating coordinated environment setup changes.
  • adding-version-from-package-file-for-healthCheck #864: Implements the same health check versioning refactor with identical changes to package.json version handling and health.config.js structure.
  • change-in-version #803: Updates the elevate-services-health-check dependency version, sharing the same dependency bump pattern in package.json.

Poem

🐰 A version hops from hard-code's cage,
Now dancing free on package's page,
SERVICE_NAME joins the health-check call,
Dynamic versions serve them all,
From 1.0 to 3.3.24—spring!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nevil-mathew

Copy link
Copy Markdown
Collaborator Author

@coderabbitai summary

@coderabbitai

coderabbitai Bot commented Nov 27, 2025

Copy link
Copy Markdown
✅ Actions performed

Summary regeneration triggered.

@coderabbitai coderabbitai Bot changed the title @coderabbitai Add SERVICE_NAME env var and improve health check versioning Nov 27, 2025
@nevil-mathew nevil-mathew changed the title Add SERVICE_NAME env var and improve health check versioning release: v3.4.0.1 – develop → staging Mar 5, 2026
@nevil-mathew nevil-mathew changed the title release: v3.4.0.1 – develop → staging release: v3.4.0-rc.1 – develop → staging Mar 5, 2026
@nevil-mathew
nevil-mathew merged commit d66e074 into staging Mar 5, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants