Skip to content

revert back logs added#875

Merged
nevil-mathew merged 1 commit into
developfrom
tenant-creation-fix
Mar 5, 2026
Merged

revert back logs added#875
nevil-mathew merged 1 commit into
developfrom
tenant-creation-fix

Conversation

@nevil-mathew

@nevil-mathew nevil-mathew commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

Release Notes

  • Refactor
    • Reduced logging overhead in event processing for improved system efficiency.
    • Simplified control flow and error handling in messaging services.
    • Code cleanup to enhance maintainability and stability.

@nevil-mathew
nevil-mathew merged commit 93ce352 into develop Mar 5, 2026
1 check failed
@coderabbitai

coderabbitai Bot commented Mar 5, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 01aea574-fddf-469e-8db3-c37efbccd4fa

📥 Commits

Reviewing files that changed from the base of the PR and between 78859b4 and e57c9dc.

⛔ Files ignored due to path filters (1)
  • src/configs/kafka.js is excluded by !src/configs/**
📒 Files selected for processing (3)
  • src/generics/kafka-communication.js
  • src/helpers/eventBroadcasterMain.js
  • src/services/account.js

Walkthrough

This pull request streamlines logging and error handling across Kafka communication and event broadcasting services. Verbose multi-line debug logs and intermediate variable assignments are removed, error logging changes from error.message to full error objects, and no-op else blocks are cleaned up—reducing overall code verbosity by ~70 lines while preserving functional behavior.

Changes

Cohort / File(s) Summary
Kafka Communication Logging
src/generics/kafka-communication.js
Removed extensive debug logging for payload construction, producer status, and per-result details in pushUserEventsToKafka and pushPayloadToKafka. Simplified error handling to log full error objects instead of detailed messages. Control flow reduces to payload construction and delegation without debug side-effects.
Event Broadcaster Logging
src/helpers/eventBroadcasterMain.js
Changed error logging from error.message to full error object in API and Kafka broadcasters. Simplified failure reporting by removing formatter prefixes and adding warning logs with broadcaster name and event group context. Adjusted blank line formatting.
Account Service Cleanup
src/services/account.js
Removed no-op else blocks in create method registration code path. Normalized catch block formatting in cache invalidation calls while preserving fire-and-forget semantics. Minor whitespace adjustments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 The logs grew long, so verbose and loud,
We trimmed the noise, made the code less proud,
Errors now speak their truths complete,
No empty blocks, no false conceit,
Cleaner paths make debugging sweet! 🌿

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tenant-creation-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant