Skip to content

fix: e2e key partition compat#6230

Merged
Jack-Works merged 3 commits into
developfrom
e2e/compat
May 23, 2022
Merged

fix: e2e key partition compat#6230
Jack-Works merged 3 commits into
developfrom
e2e/compat

Conversation

@Jack-Works

Copy link
Copy Markdown
Member

Description

Closes # (NO_ISSUE)

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions

github-actions Bot commented May 11, 2022

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request May 11, 2022 14:57 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 15, 2022 03:46 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 16, 2022 16:29 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 17, 2022 04:49 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 17, 2022 05:39 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 17, 2022 08:05 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 18, 2022 03:13 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 18, 2022 11:24 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request May 23, 2022 04:09 Inactive
@Jack-Works
Jack-Works merged commit e10a168 into develop May 23, 2022
@Jack-Works
Jack-Works deleted the e2e/compat branch May 23, 2022 10:30
@Jack-Works

Copy link
Copy Markdown
Member Author

cc @guanbinrui please pick this if we have a hotfix!

yanzhihong23 added a commit that referenced this pull request May 25, 2022
* develop: (58 commits)
  fix: typo (#6343)
  New translations en-US.json (Quenya) (#6342)
  refactor: git-info (#6332)
  fix: remove plugin border (#6331)
  chore: markdown ipfs renderer (#6339)
  refactor: replace TransactionDialog with useOpenShareTxDialog (#6181)
  Revert "fix: typo (#6335)" (#6340)
  fix: typo (#6335)
  fix: e2e key partition compat (#6230)
  fix: watcher not stopped when abort signal triggered
  fix: scale10 returns the wrong value (#6334)
  chore: rekeys package.json (#6333)
  feat: publish decryption package (#6267)
  refactor: move sns adaptor worker (#6263)
  fix: check contract (#6302)
  New translations en-US.json (Quenya) (#6328)
  [Release] New release 2.8.0 (minor) (#6275)
  chore: upgrade holoflows-kit (#6323)
  fix: tips  some ui issues (#6320)
  fix: compose select show logic (#6319)
  ...

# Conflicts:
#	packages/mask/src/plugins/Savings/SNSAdaptor/SavingsForm.tsx
guanbinrui pushed a commit that referenced this pull request May 26, 2022
* fix: e2e key partition compat

* fix: key partition

* fix: key partition path
@Lanttcat Lanttcat mentioned this pull request Jun 2, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants