refactor: replace TransactionDialog with useOpenShareTxDialog by UncleBill · Pull Request #6181 · DimensionDev/Maskbook

UncleBill · 2022-04-28T11:11:36Z

https://mask.atlassian.net/browse/MF-583
https://mask.atlassian.net/browse/MF-299
https://mask.atlassian.net/browse/MF-305
https://mask.atlassian.net/browse/MF-558

github-actions · 2022-04-28T11:17:43Z

🚀 Deployed on https://628c72fc63a68334900c6947--compassionate-northcutt-326a3a.netlify.app

UncleBill · 2022-05-06T02:08:00Z

@DimensionDev/qa Please help to verify.

guanbinrui · 2022-05-24T10:02:42Z

Replace useCallback into useAsyncFn.

UncleBill · 2022-05-24T10:20:43Z

Replace useCallback into useAsyncFn.

Already done.

Jack-Works

Although I still think we should use reject instead of null to represent the cancel state.

guanbinrui · 2022-05-24T14:31:26Z

-            return
        },
-        [transferCallback, contract?.address, gasConfig, registeredAddress, Utils?.isValidDomain],
+        [transferCallback, contract?.address, gasConfig, registeredAddress, Utils?.isValidDomain, navigate],


No navigate in deps.

guanbinrui · 2022-05-24T14:32:46Z

+                },
+            })
+            onClose()
+        } catch (err: any) {


Avoid any.

* develop: (58 commits) fix: typo (#6343) New translations en-US.json (Quenya) (#6342) refactor: git-info (#6332) fix: remove plugin border (#6331) chore: markdown ipfs renderer (#6339) refactor: replace TransactionDialog with useOpenShareTxDialog (#6181) Revert "fix: typo (#6335)" (#6340) fix: typo (#6335) fix: e2e key partition compat (#6230) fix: watcher not stopped when abort signal triggered fix: scale10 returns the wrong value (#6334) chore: rekeys package.json (#6333) feat: publish decryption package (#6267) refactor: move sns adaptor worker (#6263) fix: check contract (#6302) New translations en-US.json (Quenya) (#6328) [Release] New release 2.8.0 (minor) (#6275) chore: upgrade holoflows-kit (#6323) fix: tips some ui issues (#6320) fix: compose select show logic (#6319) ... # Conflicts: # packages/mask/src/plugins/Savings/SNSAdaptor/SavingsForm.tsx

UncleBill changed the title ~~feat: replace TransactionDialog with useOpenShareTxDialog~~ refactor: replace TransactionDialog with useOpenShareTxDialog Apr 28, 2022

UncleBill marked this pull request as draft April 28, 2022 11:13

github-actions Bot temporarily deployed to pull request April 28, 2022 11:17 Inactive

UncleBill mentioned this pull request Apr 28, 2022

feat: add Confirm as common ui #6098

Closed

guanbinrui reviewed Apr 29, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/Gitcoin/SNSAdaptor/DonateDialog.tsx Outdated

UncleBill force-pushed the refactor/share-dialog branch from faf5076 to 0784e9b Compare April 29, 2022 05:46

github-actions Bot temporarily deployed to pull request April 29, 2022 05:52 Inactive

UncleBill force-pushed the refactor/share-dialog branch 2 times, most recently from 7a368a5 to d9a8e6d Compare April 29, 2022 06:03

github-actions Bot temporarily deployed to pull request April 29, 2022 06:10 Inactive

github-actions Bot temporarily deployed to pull request April 29, 2022 07:10 Inactive

UncleBill force-pushed the refactor/share-dialog branch from 2bd66b4 to 57dc7d2 Compare May 4, 2022 08:44

github-actions Bot temporarily deployed to pull request May 4, 2022 08:51 Inactive

UncleBill force-pushed the refactor/share-dialog branch from 57dc7d2 to fb499f6 Compare May 5, 2022 07:12

UncleBill marked this pull request as ready for review May 5, 2022 07:12

github-actions Bot temporarily deployed to pull request May 5, 2022 07:19 Inactive

UncleBill force-pushed the refactor/share-dialog branch from fb499f6 to b3eee3f Compare May 6, 2022 03:17

github-actions Bot temporarily deployed to pull request May 6, 2022 03:22 Inactive

github-actions Bot temporarily deployed to pull request May 6, 2022 03:33 Inactive

UncleBill mentioned this pull request May 6, 2022

fix: watch tx confirmation event #5945

Closed

wenluomask added the Test: Failed label May 6, 2022

UncleBill force-pushed the refactor/share-dialog branch from d2db0d5 to 24ba7b7 Compare May 7, 2022 07:43

github-actions Bot temporarily deployed to pull request May 7, 2022 07:49 Inactive

UncleBill force-pushed the refactor/share-dialog branch from e7824b5 to fa3f219 Compare May 7, 2022 09:46

github-actions Bot temporarily deployed to pull request May 7, 2022 09:53 Inactive

UncleBill force-pushed the refactor/share-dialog branch from fa3f219 to 3fb7bc2 Compare May 9, 2022 05:24

github-actions Bot temporarily deployed to pull request May 9, 2022 05:30 Inactive

github-actions Bot temporarily deployed to pull request May 9, 2022 08:03 Inactive

UncleBill added 2 commits May 23, 2022 11:20

fix: remove duplicate dialogs

7adbe43

fix: checking result of asyncfn callback

cc107f9

UncleBill force-pushed the refactor/share-dialog branch from c1c8577 to cc107f9 Compare May 23, 2022 03:24

github-actions Bot temporarily deployed to pull request May 23, 2022 03:29 Inactive

github-actions Bot temporarily deployed to pull request May 23, 2022 04:00 Inactive

UncleBill force-pushed the refactor/share-dialog branch from b20fa67 to 5928367 Compare May 23, 2022 04:06

github-actions Bot temporarily deployed to pull request May 23, 2022 04:11 Inactive

UncleBill force-pushed the refactor/share-dialog branch from 5928367 to 09a68b3 Compare May 23, 2022 04:32

fix: control aborting with AbortSignal instead of a extend promise

e35c867

UncleBill force-pushed the refactor/share-dialog branch from 09a68b3 to e35c867 Compare May 23, 2022 04:32

github-actions Bot temporarily deployed to pull request May 23, 2022 04:39 Inactive

Jack-Works reviewed May 23, 2022

View reviewed changes

Comment thread packages/shared/src/contexts/common/Confirm/types.ts

Jack-Works reviewed May 23, 2022

View reviewed changes

Comment thread packages/shared/src/hooks/useOpenShareTxDialog.tsx Outdated

Jack-Works reviewed May 23, 2022

View reviewed changes

Comment thread packages/shared/src/contexts/UITaskManager.tsx Outdated

fix: follow up comments

8c67153

github-actions Bot temporarily deployed to pull request May 23, 2022 14:07 Inactive

UncleBill requested a review from Jack-Works May 24, 2022 05:31

fix: deps array

2409c2b

github-actions Bot temporarily deployed to pull request May 24, 2022 05:54 Inactive

lelenei approved these changes May 24, 2022

View reviewed changes

nuanyang233 approved these changes May 24, 2022

View reviewed changes

Jack-Works approved these changes May 24, 2022

View reviewed changes

UncleBill changed the title ~~refactor: replace TransactionDialog with useOpenShareTxDialog~~ refactor: replace TransactionDialog with useOpenShareTxDialog May 24, 2022

UncleBill merged commit 452f232 into develop May 24, 2022

UncleBill deleted the refactor/share-dialog branch May 24, 2022 12:56

guanbinrui reviewed May 24, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: replace TransactionDialog with useOpenShareTxDialog#6181

refactor: replace TransactionDialog with useOpenShareTxDialog#6181
UncleBill merged 22 commits into
developfrom
refactor/share-dialog

UncleBill commented Apr 28, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 28, 2022 •

edited

Loading

Uh oh!

Uh oh!

UncleBill commented May 6, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guanbinrui commented May 24, 2022

Uh oh!

UncleBill commented May 24, 2022

Uh oh!

Jack-Works left a comment

Uh oh!

guanbinrui May 24, 2022

Uh oh!

guanbinrui May 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

UncleBill commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

UncleBill commented May 6, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guanbinrui commented May 24, 2022

Uh oh!

UncleBill commented May 24, 2022

Uh oh!

Jack-Works left a comment

Choose a reason for hiding this comment

Uh oh!

guanbinrui May 24, 2022

Choose a reason for hiding this comment

Uh oh!

guanbinrui May 24, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

UncleBill commented Apr 28, 2022 •

edited

Loading

github-actions Bot commented Apr 28, 2022 •

edited

Loading