Skip to content

feat: properly interpret forbidden error codes #63

Merged
t-aleksander merged 3 commits into
devfrom
add-user-disable
Jun 12, 2024
Merged

feat: properly interpret forbidden error codes #63
t-aleksander merged 3 commits into
devfrom
add-user-disable

Conversation

@t-aleksander
Copy link
Copy Markdown
Contributor

@t-aleksander t-aleksander commented Jun 6, 2024

📖 Description

Core can return a forbidden error code during the enrollment. This change makes it so it's not converted into an internal server error.

🛠️ Dev Branch Merge Checklist:

Documentation

  • If testing requires changes in the environment or deployment, please update the documentation (https://defguard.gitbook.io) first and attach the link to the documentation section in this pool request
  • I have commented on my code, particularly in hard-to-understand areas

Testing

  • I have prepared end-to-end tests for all new functionalities
  • I have performed end-to-end tests manually and they work
  • New and existing unit tests pass locally with my changes

Deployment

  • If deployment is affected I have made corresponding/required changes to deployment (Docker, Kubernetes, one-line install)

🏚️ Main Branch Merge Checklist:

Testing

  • I have merged my changes before to dev and the dev checklist is done
  • I have tested all functionalities on the dev instance and they work

Documentation

  • I have made corresponding changes to the user & admin documentation and added new features documentation with screenshots for users/admins

@t-aleksander t-aleksander self-assigned this Jun 6, 2024
@t-aleksander t-aleksander marked this pull request as ready for review June 12, 2024 09:04
@t-aleksander t-aleksander merged commit fcbc012 into dev Jun 12, 2024
@t-aleksander t-aleksander deleted the add-user-disable branch June 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants