feat: add user disabling#640
Merged
Merged
Conversation
Closed
3 tasks
j-chmielewski
requested changes
Jun 7, 2024
Contributor
j-chmielewski
left a comment
j-chmielewski
left a comment
There was a problem hiding this comment.
Needs integration tests
Co-authored-by: Jacek Chmielewski <jchmielewski@teonite.com>
… into add-disable-user
| await setPassword(page); | ||
| // VPN | ||
| await page.getByTestId('enrollment-next').click(); | ||
| const deviceCreationMessage = page.waitForEvent('console'); |
Contributor
There was a problem hiding this comment.
Can we find a more reliable way of capturing this event? Perhaps check if api response status == 400?
| expect((await deviceCreationMessage).text()).toBe( | ||
| 'Failed to load resource: the server responded with a status of 400 (Bad Request)' | ||
| ); | ||
| const userActivationMessage = page.waitForEvent('console'); |
Contributor
There was a problem hiding this comment.
Can we find a more reliable way of capturing this event? Perhaps check if api response status == 400?
moubctez
reviewed
Jun 11, 2024
moubctez
reviewed
Jun 11, 2024
… into add-disable-user
j-chmielewski
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Adds the ability to disable a user.
Related PRs:
DefGuard/proxy#63
DefGuard/client#237
DefGuard/proto#19
🛠️ Dev Branch Merge Checklist:
Documentation
Testing
Deployment
🏚️ Main Branch Merge Checklist:
Testing
Documentation