Do not wait before shutdown#1498
Merged
mergify[bot] merged 3 commits intoCodeChain-io:masterfrom May 9, 2019
sgkim126:join
Merged
Do not wait before shutdown#1498mergify[bot] merged 3 commits intoCodeChain-io:masterfrom sgkim126:join
mergify[bot] merged 3 commits intoCodeChain-io:masterfrom
sgkim126:join
Conversation
Contributor
Author
sgkim126
added
bug
added 2 commits
May 9, 2019 09:59
The current code is a hotfix to bypass the crash caused by the db that is open in the other threads. But now you do not have to wait because the previous commits fixed the main thread to wait for joining the child threads.
foriequal0
approved these changes
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is a hotfix to bypass the crash caused by the db that is open in the other threads.
But now you do not have to wait because it fixes the main thread to wait for joining the child threads.
It fixes #348.