Remove Reactor#1496
Merged
sgkim126 merged 3 commits intoCodeChain-io:masterfrom May 9, 2019
sgkim126:reactor
Merged
Conversation
It was designed to create a thread for the future, but we don't use it. I think it's better to re-design the Reactor because the future will be stabilized in the standard library soon or use the tokio directly.
Contributor
Author
|
@kseo Please review it. |
Contributor
Author
|
@kseo Please review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was designed to create a thread for the future, but we don't use it.
I think it's better to re-design the Reactor because the future will be
stabilized in the standard library soon or use the tokio directly.