Skip to content

Translation to Simplified Chinese#456

Open
championdot wants to merge 2 commits intozonemaster:developfrom
championdot:translation-update
Open

Translation to Simplified Chinese#456
championdot wants to merge 2 commits intozonemaster:developfrom
championdot:translation-update

Conversation

@championdot
Copy link
Copy Markdown

@championdot championdot commented Apr 7, 2026

Purpose

This PR gives translation of the Zonemaster-CLI string into Simplified Chinese.

Changes

Adds share/zh.po file.

How to test this PR

Unit tests should pass and ../../zonemaster-engine/util/check-msg-args zh.po should pass and the PO file should be tidied by make POFILES=zh.po tidy-po (see "Translating Engine, CLI and Backend")

@championdot
Copy link
Copy Markdown
Author

Added Simplified Chinese translation for zonemaster-cli.
All messages translated and checked.

@matsduf matsduf changed the title “翻译更新:增加中文” Translation to Simplified Chinese Apr 8, 2026
@matsduf
Copy link
Copy Markdown
Contributor

matsduf commented Apr 8, 2026

@championdot, this would only give translation to messages around the test, not the messages from the test itself. To get full translation of zonemaster-cli requires translation of Zonemaster-Engine too. How much value would this give when you have to understand English anyway to understand a test?

What is the difference between this PR and #455?

@matsduf matsduf added T-Feature Type: New feature in software or test case description A-Translation Area: Documentation of, implementation of or actual translation of text labels Apr 8, 2026
@championdot
Copy link
Copy Markdown
Author

championdot commented Apr 9, 2026

@championdot, this would only give translation to messages around the test, not the messages from the test itself. To get full translation of zonemaster-cli requires translation of Zonemaster-Engine too. How much value would this give when you have to understand English anyway to understand a test?

Of course, I will gradually complete the Chinese translation of all Zonemaster components. I believe this will better promote Zonemaster, and I highly value the comprehensiveness of this system's detection.

#456 is based on #455 with some translation changes.

@matsduf
Copy link
Copy Markdown
Contributor

matsduf commented Apr 9, 2026

@championdot, thank you for your contribution!

Your translation only contains 32 of 39 msgids. Please see "Translating Engine, CLI and Backend" for how to contribute with a PO file in the same format as the other PO files.

Please also keep commit messages and other comments and documentation in English.

For me it looks like #455 is just redundant and is doing the same thing, but against the master branch. The PR is against develop branch, which is how we work. Please continue with this. If you want to reach out via email, you can find my address via my Github profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Translation Area: Documentation of, implementation of or actual translation of text T-Feature Type: New feature in software or test case description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants