Widget Twitter account @zfmodules#465
Widget Twitter account @zfmodules#465localheinz merged 3 commits intozendframework:masterfrom gianarb:feature/twitter-widget
Conversation
There was a problem hiding this comment.
Can you move this to a different file?
There was a problem hiding this comment.
Not in a view helper?
do I move script embedding into layout?
There was a problem hiding this comment.
It's going to be reloaded every time at every page here. If you move it to $this->headScript() it's much better IMO
|
Good idea. However we need to focus on tweet using api. |
There was a problem hiding this comment.
Keep account name in config
There was a problem hiding this comment.
What is it? It's user id?
There was a problem hiding this comment.
Every twitter's widget has a id :)
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry I copied code generated by my italian Twitter :)
There was a problem hiding this comment.
So add it also to config :)
There was a problem hiding this comment.
In my opinion in configuration this params not works.. If I insert this params how arguments of invoke how do you think?
There was a problem hiding this comment.
@Ocramius @ins0 @localheinz opinion about this stuff? :) Thanks
|
Rebased.. feedback? In my opinion this repository is for zfmodules site not for an abstract zf modules repository.. :) Move this data into the config is unnecessary |
|
I'm not so sure of the actual value of this as I think that you can already see the latest modules when you're on the site. Also, the right column seems a bit crowded with the widget! Since it pushes down the list of newly registered developers, it also decreases the value of that list. What do you think? Maybe a simple follow button in the header is sufficient? |
|
Yes, this is a zfmodules account, in this moment publish only new modules 2015-03-09 12:32 GMT+01:00 Andreas Möller notifications@github.com:
Gianluca Arbezzano |
|
|
|
Ping @localheinz @Ocramius :) :) |
|
ping @localheinz can you push this pr or there are a problems? 😄 |
Widget Twitter account @zfmodules
|
Np :) thank you!! :) 2015-03-26 14:04 GMT+01:00 Andreas Möller notifications@github.com:
Gianluca Arbezzano |
4 participants
Hi!
I opend a new twitter account @zfmodules for this site.
Ifttt tweet every new module updated