[WIP] Feature: Flash Messenger Error Messages#421
[WIP] Feature: Flash Messenger Error Messages#421Ocramius merged 25 commits intozendframework:masterfrom
Conversation
6b7a105 to
7b97bc8
Compare
There was a problem hiding this comment.
Lots of translate calls that aren't actually needed
There was a problem hiding this comment.
Also, avoid calling getTranslator everywhere
There was a problem hiding this comment.
@Ocramius should i avoid using translate in order that at some point the site gets multi language or calling the translator once into a var and translate it into the loop?
|
@Ocramius would be nice if you could review this like meat through a meat chipper 🍖 // or everyone else of course :) |
There was a problem hiding this comment.
Avoid this else: do this assign operation earlier
|
@ins0 done |
|
thanks @Ocramius for your first review, changed most of the suggestions - others waiting for reply 😸 |
e4c616a to
61ebb03
Compare
There was a problem hiding this comment.
throw InvalidRequestDataException::fromInvalidPostRequest($request)
85a59be to
b7676ff
Compare
|
@Ocramius may take the final look over this, please? 😃 |
|
ping @Ocramius :) |
|
👍 |
[WIP] Feature: Flash Messenger Error Messages
|
thanks @Ocramius @localheinz 👍 |
This PR