Conversation
5 tasks
ilan-gold
approved these changes
Jan 9, 2026
kylebarron
reviewed
Jan 9, 2026
Comment on lines
+63
to
+64
| let object_store: Arc<dyn zarrs_object_store::object_store::ObjectStore> = | ||
| external_object_store.into_dyn(); |
There was a problem hiding this comment.
To be clear here, what this is doing is taking the configuration from an existing obstore store and recreating a new store with the same parameters in the currently-linked object_store crate. So that means any connection pooling will not be shared between the user's input obstore instance and the instance you use to make your own fetches.
That's why the original idea in pyo3-object_store was that downstream crates would re-export the obstore store creation API, so that there wouldn't be any of this "dynamic linking" across crates. Since we don't have real dynamic linking, in effect we have to re-create all the necessary resources in the target pyo3 module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.