Rewrites the ensure_text implementation#201
Merged
jakirkham merged 3 commits intozarr-developers:masterfrom Nov 3, 2019
jakirkham:rewrite_ensure_text
Merged
Rewrites the ensure_text implementation#201jakirkham merged 3 commits intozarr-developers:masterfrom jakirkham:rewrite_ensure_text
ensure_text implementation#201jakirkham merged 3 commits intozarr-developers:masterfrom
jakirkham:rewrite_ensure_text
Conversation
Borrows the `ensure_text_type` function's implementation from Zarr and uses it to rewrite the `ensure_text` function. Basically it makes sure any `bytes`-like data can be encoded as text with zero-copy. Also avoids getting muddled in Python 2/3 details as well, which should make it easier to maintain.
|
Hello @jakirkham! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-24 02:46:04 UTC |
To fix some lint, go ahead and replace `l` with `s` in `ensure_text`.
Member
Author
|
Not sure what is up with the coverage report. When drilling down into it, am seeing 100% on the individual files. |
This was referenced Nov 3, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Borrows the
ensure_text_typefunction's implementation from Zarr and uses it to rewrite theensure_textfunction. Basically it makes sure anybytes-like data can be encoded as text with zero-copy. Also avoids getting muddled in Python 2/3 details as well, which should make it easier to maintain.TODO:
tox -e py37passes locallytox -e py27passes locallytox -e docspasses locally