Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

NT IRN app tweaks, bugfixes and code refactor#20421

Merged
Moltijoe merged 6 commits intoyogstation13:masterfrom
warface1234455:money
Oct 1, 2023
Merged

NT IRN app tweaks, bugfixes and code refactor#20421
Moltijoe merged 6 commits intoyogstation13:masterfrom
warface1234455:money

Conversation

@warface1234455
Copy link
Copy Markdown
Contributor

@warface1234455 warface1234455 commented Sep 23, 2023

Document the changes in your pull request

Add an option to toggle between using departmental budget or cargo budget when requesting a package
Using department budget to order now actually show the departmental name to avoid confusion
Fixes issue when departmental budget amount not appearing on the app
Fixes NT IRN app not printing requisition paper
Fixes modular computer's NT IRN app showing buyer as unknown because it doesnt recognize the pda
Refactored code a bit
private crate can now be sent back to CC if unlocked

Why is this good for the game?

Having it as a toggle allows you to conveniently order things without affecting the departmental budget or cargo budget. Currently, switching budgets requires removing the ID, which is inconvenient.

Testing

tested on local, results:
buget

budget2

Changelog

🆑
tweak: Add an option to toggle between using departmental budget or cargo budget when requesting a package
tweak: Using department budget to order now actually show the departmental name to avoid confusion
bugfix: Fixes issue when departmental budget amount not appearing on the app
bugfix: Fixes NT IRN app not printing requisition paper
bugfix: Fixes modular computer's NT IRN app showing buyer as unknown because it doesnt recognize the pda
tweak: Refactored code a bit
tweak: private crate can now be sent back to CC if unlocked
/:cl:

@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Javascript This PR contains javascript code. Tweak This PR contains changes to the game. labels Sep 23, 2023
@github-actions github-actions bot added the tgui This PR affects TGUI label Sep 23, 2023
@warface1234455 warface1234455 changed the title NT IRN app tweaks and bugfixes NT IRN app tweaks, bugfixes and code refactor Sep 24, 2023
@MajManatee
Copy link
Copy Markdown
Contributor

the word "Budget ordering" makes me think you are using a discounted service, or ordering the worse versions of gear, rather than using a departmental budget

@warface1234455
Copy link
Copy Markdown
Contributor Author

warface1234455 commented Sep 26, 2023

the word "Budget ordering" makes me think you are using a discounted service, or ordering the worse versions of gear, rather than using a departmental budget

how about "departmental purchasing", i think this is more suitable

Copy link
Copy Markdown
Contributor

@Chubbygummibear Chubbygummibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TGUI looks fine, the linter isn't throwing a fit, and the addition of the video demo gives me confidence in its functionality

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs Javascript This PR contains javascript code. tgui This PR affects TGUI Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants