This repository was archived by the owner on May 22, 2025. It is now read-only.
Adds new Lavaland Biodome Ghost Spawn: The Fisherman, in a Fishing Pier Biodome#14746
Merged
KillerOrcaCora merged 15 commits intoyogstation13:masterfrom Jul 16, 2022
VaelophisNyx:Biodomefishing
Merged
Adds new Lavaland Biodome Ghost Spawn: The Fisherman, in a Fishing Pier Biodome#14746KillerOrcaCora merged 15 commits intoyogstation13:masterfrom VaelophisNyx:Biodomefishing
KillerOrcaCora merged 15 commits intoyogstation13:masterfrom
VaelophisNyx:Biodomefishing
Conversation
need new sprite for the fishing vendor restock.
splish splash
Contributor
|
A lot of biodomes feature entrances on at least two sides. Can you split the lake in half and have a small entry area north? |
Contributor
Author
|
Yeah I can look into it |
Contributor
|
Do we really need all those vending machines? |
Contributor
Author
|
I could probably remove some. I'm just unsure what to fill the space with however |
Contributor
Author
|
Updated to remove some vendors, and shuffled some stuff around, namely the space cash and arcade machine |
ToasterBiome
approved these changes
Jul 13, 2022
Yogbot-13
added a commit
that referenced
this pull request
Jul 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fish fear him
Document the changes in your pull request
Adds a new Biodome to lavaland based on fishing, complete with a small bar & kitchen setup for serving miners and the two fishermen that spawn here. Also features a Gift Shop!
PR additionally makes Lavaboats work on water turfs, mostly for RP since water is (currently) safe.
Additionally fixes a missing fishing vendor restock item
adds proper names to lavaland biodome areas, so they're easier to locate in code and in mapping tools.
Spriting
new fishing vendor restock
enlarged
Wiki Documentation
Lavaland page will need a mention of Fishermen existing
Ghost page will need the Fisherman Sleeper added to the table of possible ghost spawns
Ruins page will need an entry and screenshot of this ruin
Changelog
🆑 VaelophisNyx, @nmajask, @KillerOrcaCora
rscadd: Added new Fishing Pier Biodome to Lavaland
rscadd: Added new Fisherman Sleeper ghost spawn role
bugfix: fixed fishing vendor restock item not existing
tweak: lavaboats can now move on water
tweak: lavaland biodome areas now properly named
imageadd: adds a new fishing vendor restock sprite
/:cl: