This repository was archived by the owner on May 22, 2025. It is now read-only.
Fixed and Tweaked Some Stuff With the Crew Console Interface#11570
Merged
JamieD1 merged 4 commits intoyogstation13:masterfrom Jun 19, 2021
Merged
Fixed and Tweaked Some Stuff With the Crew Console Interface#11570JamieD1 merged 4 commits intoyogstation13:masterfrom
JamieD1 merged 4 commits intoyogstation13:masterfrom
Conversation
Here are the changes: -Added IDs for job that didnt have them (Paramedic, Psychiatrist, Mining Medic, Signal Technician, Clerk, Tourist, an Artist), now they will appear in the right place and have the correct color. -Removed the map from the interface -Added new civilian color that civilians use (#535353)
Yogbot-13
added
Fix
Why do you yell at me now instead of when I compile you 5 times
Contributor
|
Looks good, you’ll have to clean up the map asset though so it’s not sent for no reason |
Hope this works
Contributor
Author
|
damn that didn't work and I don't have time to fix it, I'm going to be away all week |
Contributor
|
Damn, it’s fine, not that big a deal anyhow. I might do it after this PR is merged if I have time/don’t forget. |
Potentially fixes the check fail by removing an unused var
JamieD1
approved these changes
Jun 19, 2021
Yogbot-13
added a commit
that referenced
this pull request
Jun 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Documentation
Intent of your Pull Request
Added IDs for job that didn't have them (Paramedic, Psychiatrist, Mining Medic, Signal Technician, Clerk, Tourist, an Artist), now they will appear in the right place and have the correct color. Additionally, I removed the map from the interface and added a new civilian color that civilians use in the crew console (#535353).
Why is this change good for the game?
The missing job IDs are a mistake I assume and it causes the layout to look wrong. The map serves little purpose and I've that seen some people dislike it. The new color is just to help the list easier to comprehend at a glance.
Wiki Documentation
Briefly describe your PR and the impacts of it, in layman's terms.
This will be the basis of the Wiki entry for your PR, and more information / detail is better for Wiki editors to integrate.
Fixed and tweaked some stuff with the crew console interface
What should players be aware of when it comes to the changes your PR is implementing?
The crew console looks better I guess
What general grouping does this PR fall under?
TGUI fixes
Are there any aspects of the PR that you would like us not to mention on the Wiki?
How long it took me to find where ijob was stored
If there are any numerical values involved in your PR that will be relevant to a player, please note them here.
Nope
Changelog
🆑
bugfix: fixed some jobs missing IDs in the crew console
tweak: Removed the map an gave civilians their own color on the crew console
/:cl: