feat: add fluent hidden options - #77
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@codex please do a deep review of this pr |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d48be511f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Review follow-up complete on
Validation:
Both review threads were answered individually and resolved. |
|
@codex review please |
|
Latest review round complete on Two findings were reproducible and are fixed:
The reported Validation:
All three threads were answered with evidence and resolved; no active review thread remains. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b4e6630e4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Follow-up review round complete on Both new findings were reproducible and are fixed:
Validation:
Both threads were answered individually and resolved. No active review thread remains. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d2b801d7b6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
6bbd293 to
e084e20
Compare
|
Published review fixes in Key changes:
Validation:
All 11 outstanding review threads received individual replies and were resolved. |
|
Addressed the two Codex findings in
Validation:
Both Codex threads received individual replies and were resolved. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32e6d6a1b9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a660dbd52
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Summary
.Hidden(bool)metadata for direct command options, options-group properties, manually registered globals, and typed global optionsHiddenAliases/.HiddenAlias(...)migration metadata so canonical options remain discoverable while legacy route/global aliases stay accepted only by CLI/REPL parsing; includes direct parameters, options-group properties, manual globals, and typed globals.Hidden(false)to restore visibilityAddGlobalOptionCoredescriptor for binary compatibility with already-compiledRepl.DefaultsassembliesValidation
eafe8f4: 1,413 total; 1,412 passed; 1 external MCP Inspector smoke skipped; 0 failed0838355; current-head CI oneafe8f4is running after final test-matrix coverageRepl.Defaultswith candidateRepl.Corepassedorigin/mainCloses #76