Stop using enableBreakpointsFor in package.json under debuggers contribution

[isidorn]

Hi VS Code dev here 👋

Please stop using the enableBreakpointsFor field in your package.json.
It is deprecated and we will stop supporting it in our next stable release (in a month).
Here's where you use it https://github.com/felixfbecker/vscode-php-debug/blob/master/package.json#L119

Here's an alternative how you should use it
https://github.com/microsoft/vscode-mock-debug/blob/master/package.json#L112

So the breakpoints attribute is no longer under debuggers that is the difference.

Here's how react native tackled this deprecation microsoft/vscode-react-native#1450

All the best
isidor

[aredridel]

This just bit me in the insiders release, thank you for reporting it @isidorn!

[JulianCBC]

Just so the severity of this is clear: this breaks the extension rendering it almost completely unusable.

@felixfbecker I note that you haven't done any development on this extension in over a year, if you've abandoned it, please make that clear so people's expectations are set appropriately.

[isidorn]

Please note that a fix for this is a 10 minute effort I think.
If nobody from the mainterns whats to do it and if nobody from the community is interested I can create it.

[JulianCBC]

@isidorn the issue isn't necessarily the fix, it's a completely trivial change to the point that I'm surprised VSC doesn't have some form of permanent backwards compatibility, the issue is releasing this in Felix's name, which you can't do.

Felix hasn't touched this repo in over a year, and there are two forks with both more active development and packages published in the VSC extension directory:

• https://github.com/tiansin/vscode-php-debug.git
• https://github.com/robberphex/vscode-php-debug.git

@tiansin's fork has fixed this particular issue and Works For Me as a replacement to this extension.

So if Felix has indeed abandoned this extension, the best path forwards is to make that clear (whatever that means) so people know to migrate to one of these forks.

[MattGrdinic]

Yup. And by not fixing this before a full release, you've just broken the 3.9 million installs this extension has.

[dsclee1]

I've created a pull request to fix the issue. #428

[lwohlhart]

rather unfortunate deprecation policy but well, okay.
Does anybody have a guess if @felixfbecker will continue.
Really love his work would hate to have to swap to another implementation.

[xpertbot]

For other developers that need this extension to work for time sensitive projects and need a quick fix, I am unsure when @felixfbecker will apply this fix. I forked the repo and added the recommended fix into it, also published the extension for others, it lives here. Note: I will not maintain it, I just need the extension to work without affecting my workflow completely.

[aredridel]

Do note there are two other forks.

[xpertbot]

@aredridel I saw them and was planning on contributing to them however, 1 is in Chinese, which I do not speak.. and the other last commit was on 2019, so it's multiple versions behind. Just wanted to share a quick fix that will work for the time being, until @felixfbecker fixes it.

[gentig]

You can fix this by doing the following:

1. go to vscode extension directory: e.g. .vscode\extensions\felixfbecker.php-debug-1.13.0
2. Open package.json then remove the following from the file

"enableBreakpointsFor": {
          "languageIds": [
            "php"
          ]
        },

and add the following right above "debuggers"

"breakpoints": [
			{
				"language": "php"
			}
		]

3. Reload vscode

[RAFA3L]

Thanks @gentig