Fix CHIP-0002 precision#784
Open
Rigidity wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the WalletConnect API contract for coin/lineage amounts from
u64/numberto anAmount(number-or-string) representation, which can impact external clients and parsing of incoming spend bundles.Overview
Fixes CHIP-0002 precision issues by switching WalletConnect coin amounts to the shared
Amounttype (string-or-number) instead of plainu64/JSnumber.Backend endpoints now emit amounts via
Amount::u64(...)and consume them by convertingAmountback tou64with validation/erroring on invalid values. Frontend bindings and WalletConnect command Zod schemas were updated to acceptamountasnumber | string, and locale message source line references were refreshed due to unrelated file shifts.Reviewed by Cursor Bugbot for commit 385ec85. Bugbot is set up for automated code reviews on this repo. Configure here.