Skip to content

Fix CHIP-0002 precision#784

Open
Rigidity wants to merge 2 commits into
mainfrom
fix-chip-0002-precision
Open

Fix CHIP-0002 precision#784
Rigidity wants to merge 2 commits into
mainfrom
fix-chip-0002-precision

Conversation

@Rigidity
Copy link
Copy Markdown
Collaborator

@Rigidity Rigidity commented May 18, 2026

Note

Medium Risk
Changes the WalletConnect API contract for coin/lineage amounts from u64/number to an Amount (number-or-string) representation, which can impact external clients and parsing of incoming spend bundles.

Overview
Fixes CHIP-0002 precision issues by switching WalletConnect coin amounts to the shared Amount type (string-or-number) instead of plain u64/JS number.

Backend endpoints now emit amounts via Amount::u64(...) and consume them by converting Amount back to u64 with validation/erroring on invalid values. Frontend bindings and WalletConnect command Zod schemas were updated to accept amount as number | string, and locale message source line references were refreshed due to unrelated file shifts.

Reviewed by Cursor Bugbot for commit 385ec85. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant