make-json: generated file missing theme textdomain prefix

[mcguffin]

Bug Report

I'll keep it brief – might hopefully save someones time. ;)

Translations folder in a theme – just as expected by load_theme_textdomain():

languages/
    theme-slug.pot
    de_DE.po
    de_DE.mo

CLI Command

wp i18n make-json languages/*.po --no-purge

The result

languages/
    theme-slug.pot
    de_DE.po
    de_DE.mo
    languages/de_DE-a0623ef93657e56554c5ddda522ed690.json

The translation will not load.
wp_set_script_translations() expects the file to live in {textdomain}-{locale}-{md5}.json.
After renaming it accordingly the translation loads.

[swissspidy]

Related: #151 (comment)

[swissspidy]

Just copying my comment from the above ticket, which still seems accurate:

wp i18n make-json does indeed not support a --domain because it is actually not used. That is indeed problematic.

The script just turns <source>.po into <source>-hash.json, which does not work as you mentioned.

I think the solution here should be:

1. Check --domain argument for text domain
2. If not passed, check PO file for X-Domain header.
3. Prefix JSON file with text domain in case it is missing.