Merged
Conversation
The subsequent assertions make `run` over `try` moot.
Member
Author
|
Hmmm... looks like this caused them to fail on GitHub Actions! I'll try again another day. |
Member
Author
|
I've replaced |
schlessera
approved these changes
Jun 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sedsyntax is different on MacOS than Ubuntu (i.e. the GitHub Actions runner) so running the tests fail for me during development.I have made the bash command conditional – check for Darwin and run the appropriate command.I have replacedsedwithawk.taris returning a bad exit code causing therunstatements to fail. I've changed these totryand the subsequent assertions in the tests should mean ignoring the exit code at that point is acceptable.This might make PR #58 pass too.