Add wrynose (OpenEmbedded 5.0) compatibility#166
Open
ti-kamlesh wants to merge 1 commit into
Open
Conversation
|
Can one of the admins verify this patch? |
ti-kamlesh
force-pushed
the
wrynose-compat
branch
from
f304dfc to
b0927ea
Compare
wrynose is the codename for the OE-core 5.0 / Yocto 5.1 release.
The following changes are required for meta-wolfssl to build cleanly
on this release:
conf/layer.conf:
- Add 'wrynose' to LAYERSERIES_COMPAT_wolfssl so bitbake accepts
the layer without a compatibility warning/error.
recipes-wolfssl/wolfssl/wolfssl_5.9.1.bb:
- Remove explicit 'S = "${WORKDIR}/git"'. wrynose bitbake.conf now
auto-derives S from the git fetcher using ${BP} as destsuffix;
setting it to ${WORKDIR}/git triggers a fatal QA error:
"Using S = ${WORKDIR} is no longer supported".
- Fix RPROVIDES_${PN} -> RPROVIDES:${PN}. The underscore-based
variable override syntax was removed in wrynose and causes a
parse failure.
recipes-wolfssl/wolfprovider/wolfprovider_1.1.1.bb:
recipes-wolfssl/wolfmqtt/wolfmqtt_2.0.0.bb:
recipes-wolfssl/wolfssh/wolfssh_1.4.22.bb:
recipes-wolfssl/wolfengine/wolfengine_1.4.0.bb:
recipes-wolfssl/wolftpm/wolftpm_3.10.0.bb:
recipes-wolfssl/wolfpkcs11/wolfpkcs11_2.0.0.bb:
recipes-wolfssl/wolfclu/wolfclu_0.1.8+master.bb:
recipes-wolfssl/wolfssl-py/wolfssl-py_5.8.4.bb:
recipes-wolfssl/wolfcrypt-py/wolfcrypt-py_5.8.4.bb:
recipes-examples/wolfprovider/wolfprovidercmd/wolfprovidercmd.bb:
recipes-examples/wolftpm/wolftpm-wrap-test.bb:
recipes-examples/wolfssl-py/wolf-py-tests/wolf-py-tests_5.6.0.bb:
- Remove 'S = "${WORKDIR}/git"' for the same reason as above.
wrynose auto-sets S for git fetchers; explicit assignment to
${WORKDIR}/git triggers the fatal QA error.
recipes-wolfssl/wolfprovider/wolfprovider_1.1.1.bb:
recipes-wolfssl/wolfclu/wolfclu_0.1.8+master.bb:
- Fix RPROVIDES_${PN} -> RPROVIDES:${PN}. Underscore override
syntax was removed in wrynose.
recipes-wolfssl/wolfssl-py/wolfssl-py_5.8.4.bb:
- Fix RDEPENDS_${PN} -> RDEPENDS:${PN}. Same reason.
inc/wolfcrypttest/wolfssl-enable-wolfcrypttest.inc:
inc/wolfcryptbenchmark/wolfssl-enable-wolfcryptbenchmark.inc:
- Add 'wrynose' to modern_series. Without this the version selector
falls back to the legacy .inc file which contains do_install_append()
syntax that bitbake rejects in wrynose.
recipes-examples/wolfcrypt/wolfcrypttest/wolfcrypttest.bb:
recipes-examples/wolfcrypt/wolfcryptbenchmark/wolfcryptbenchmark.bb:
- Change S from "${WORKDIR}/git/wolfcrypt/{test,benchmark}" to
"${UNPACKDIR}/${BP}/wolfcrypt/{test,benchmark}". In wrynose the
git fetcher default destsuffix changed from 'git' to '${BP}', so
the source tree lands at ${UNPACKDIR}/${BP}/ rather than
${WORKDIR}/git/. The old path causes do_populate_lic to fail with
"LIC_FILES_CHKSUM points to an invalid file".
Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
ti-kamlesh
force-pushed
the
wrynose-compat
branch
from
b0927ea to
4caa6a1
Compare
Author
|
@night1rider Could you please take a look I can fix the review comments |
Contributor
|
@ti-kamlesh, thanks for opening this PR! We are going to treat this as a feature request. I will open a new PR soon and tag you so you can test it on your end. Looking through the changes, I can already see a few potential issues, but we definitely should add support for the newest Yocto LTS. Once the new PR is up, I will close this one out and reference it in the new PR. |
Author
|
@night1rider Thanks for the support, any rough timeline so that we can plan things accordingly? |
Contributor
|
@ti-kamlesh I will hopefully have the PR up and tested (Added to internal CI as well) on my end by EOD tomorrow and would just need your confirmation afterwards that it builds for you as well. I would hope this could be merged in by Friday, but could see it going to Monday at the latest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrynose is the codename for the OE-core 5.0 / Yocto 5.1 release. Several changes are required for meta-wolfssl to build cleanly on this release:
conf/layer.conf:
recipes-wolfssl/wolfssl/wolfssl_5.9.1.bb:
inc/wolfcrypttest/wolfssl-enable-wolfcrypttest.inc: inc/wolfcryptbenchmark/wolfssl-enable-wolfcryptbenchmark.inc:
recipes-examples/wolfcrypt/wolfcrypttest/wolfcrypttest.bb: recipes-examples/wolfcrypt/wolfcryptbenchmark/wolfcryptbenchmark.bb: