Merged
Conversation
Signed-off-by: Andy Arnold <anarnold@redhat.com>
seems to be causing a merge conflict
✅ Deploy Preview for windup-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
abrugaro
suggested changes
Feb 8, 2024
anarnold97
commented
Feb 8, 2024
anarnold97
commented
Feb 8, 2024
anarnold97
commented
Feb 8, 2024
anarnold97
commented
Feb 8, 2024
anarnold97
commented
Feb 8, 2024
anarnold97
commented
Feb 8, 2024
sshveta
reviewed
Feb 8, 2024
anarnold97
commented
Feb 8, 2024
anarnold97
commented
Feb 8, 2024
sshveta
reviewed
Feb 8, 2024
abrugaro
suggested changes
Feb 8, 2024
Signed-off-by: Andy Arnold <anarnold@redhat.com>
Signed-off-by: Andy Arnold <anarnold@redhat.com>
sshveta
reviewed
Feb 10, 2024
sshveta
reviewed
Feb 10, 2024
sshveta
reviewed
Feb 10, 2024
sshveta
reviewed
Feb 10, 2024
anarnold97
commented
Feb 11, 2024
abrugaro
suggested changes
Feb 12, 2024
abrugaro
left a comment
abrugaro
left a comment
There was a problem hiding this comment.
The PR was ok before, looks like some changes were rollbacked
| [discrete] | ||
| === Running cloud-readiness rules | ||
|
|
||
| The following command analyzes the `com.acme` and `org.apache` packages of the link:https://github.com/windup/windup/blob/master/test-files/jee-example-app-1.0.0.ear[jee-example-app-1.0.0.ear] example EAR archive for migrating to JBoss EAP 7. It also evaluates for cloud readiness: |
There was a problem hiding this comment.
There is no option to specify packages to analyze in the new mta-cli version so analyzes the com.acme and org.apache packages should be removed
| [discrete] | ||
| === Running {ProductShortName} on source code | ||
|
|
||
| The following command analyzes the `org.jboss.seam` packages of the link:https://github.com/windup/windup/tree/master/test-files/seam-booking-5.2[seam-booking-5.2] example source code for migrating to JBoss EAP 6. |
There was a problem hiding this comment.
There is no option to specify packages to analyze in the new mta-cli version so the org.jboss.seam packages should be removed.
anarnold97
commented
Feb 12, 2024
anarnold97
commented
Feb 13, 2024
This was referenced Feb 14, 2024
Collaborator
Author
|
See SLACK conversation - awesome makes sense. If you don't mind merging those just to fix what we currently have that would be awesome if it doesn't overlap too much with your changes. Otherwise you are free to just take those changes and incorporate them into yours up to you |
This was referenced Feb 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA