refactor: fix encoding and move str2bool to shared utils#352
Merged
Conversation
…digit numbers (#283) Replace phone_digits**3 | phone_digits**5 with an explicit phone.tsv list of known short numbers (110, 119, 120, 12306, 10086, etc.). This fixes 3-digit numbers like 500 being read as 五零零 instead of 五百. 11-digit mobile numbers (phone_digits**11) are unchanged.
- Add encoding="utf-8" to open() in tn/main.py and itn/main.py for Windows compatibility - Move str2bool from itn/main.py to tn/utils.py to remove TN's dependency on ITN module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding="utf-8"toopen()in CLI entry points (tn/main.py,itn/main.py) for Windows compatibilitystr2boolfromitn/main.pytotn/utils.py, removing TN's circular dependency on ITNTest plan
python -m tnandpython -m itnwork correctly