fix: enumerate known short phone numbers instead of matching all 3/5 digits#351
Merged
Conversation
…digit numbers (#283) Replace phone_digits**3 | phone_digits**5 with an explicit phone.tsv list of known short numbers (110, 119, 120, 12306, 10086, etc.). This fixes 3-digit numbers like 500 being read as 五零零 instead of 五百. 11-digit mobile numbers (phone_digits**11) are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283
Summary
Replace
phone_digits**3 | phone_digits**5with an explicitphone.tsvlist of known short numbers (110, 119, 120, 12306, 10086, 95xxx, etc.). This fixes 3/5-digit numbers like500being read as五零零instead of五百.11-digit mobile numbers (
phone_digits**11) are unchanged.Examples
Test plan