feat: add 亿级 support and strip commas for Chinese TN#337
Merged
Conversation
Use cdrewrite to remove commas between digits before matching numbers in the Measure rule, so western-formatted numbers like 1,000,000米 correctly normalize to 一百万米. Note: numbers exceeding 万级 (>99,999,999) still need 亿级 support in Cardinal (#223), which is tracked separately.
- Extend Cardinal number FST to support 亿级 (9-13 digit numbers) using two 4-digit blocks to prevent ambiguity with shorter numbers - Strip commas between digits in Measure rule for western-formatted numbers like 299,792,458米 - Refactor Cardinal: extract four_nonzero/four_any helpers, remove redundant add_weight and rmpunct from number patterns Examples: 299,792,458米 => 两亿九千九百七十九万二千四百五十八米 100000001 => 一亿零一 1,000,000米 => 一百万米
pengzhendong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #223
Closes #284
Summary
numberFST to handle 9-13 digit numbers using two 4-digit blocks (four_nonzero+万+four_any) to prevent ambiguity with shorter numberscdrewritefour_nonzero/four_anyhelpers, remove redundantadd_weightandrmpunctfrom number patternsExamples
Test plan