refactor: share rule instances to speed up FST construction#333
Merged
Conversation
Each rule class now accepts optional dependency params (e.g. cardinal=None) and reuses injected instances instead of creating its own. Normalizer and InverseNormalizer build all rules once in topological order via a new build_tagger_and_verbalizer() method, sharing instances across tagger and verbalizer construction. Before: Cardinal was instantiated 60 times per English Normalizer build. After: Cardinal is instantiated once. Performance improvement: - English Normalizer build: 71s -> 17s (4x faster) - Full test suite: 196s -> 88s (2.2x faster)
pengzhendong
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cardinal=None), reusing injected instances instead of creating new ones internallybuild_tagger_and_verbalizer(), sharing instances across tagger and verbalizer constructionbuild_tagger()+build_verbalizer()for backward compatibilityBefore:
Cardinal()was instantiated 60 times per English Normalizer build.After:
Cardinal()is instantiated once.Performance
Test plan