feat(error): offset-based span tracking and richer display#38
Merged
weihanglo merged 2 commits intogit-format-patchfrom Feb 11, 2026
Merged
feat(error): offset-based span tracking and richer display#38weihanglo merged 2 commits intogit-format-patchfrom
weihanglo merged 2 commits intogit-format-patchfrom
Conversation
This kinda follows the error pattern of the toml crate. And along with span-tracking, we make error enums structs as well as turn them into private kinds enums.
24 tasks
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kinda modeled after https://crates.io/crates/toml: https://github.com/toml-rs/toml/blob/a26defd343a2fdb04a193b3fb70b58c80d48ef71/crates/toml/src/de/error.rs#L104-L165. See snapshots for examples.