fix: handle numbers above 6 digits in formatMoney (#7956)#7969
Merged
alexander-akait merged 1 commit intoMar 10, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shivxmsharma
force-pushed
the
fix/format-money-large-numbers
branch
from
08d9ced to
5285da2
Compare
alexander-akait
approved these changes
Mar 10, 2026
pranjalisr
pushed a commit
to pranjalisr/webpack.js.org
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the formatMoney helper in Support.jsx which only inserted a single comma, incorrectly formatting numbers above 6 digits (e.g.
1234567→1234,567instead of1,234,567).Replaced the manual string slicing with
Number.toLocaleString('en-US')which correctly handles thousands separators for any number length.Closes #7956
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
No — this is a one-line utility fix. The function behavior can be verified visually on the Support/Sponsors page.
Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No documentation changes needed.
Use of AI
AI (Gemini CLI) was used to navigate the codebase and identify the bug location. The fix was determined through code analysis. I follow webpack's AI Policy.