fix: improve accessibility across Navigation, Footer, and PageNotFound#7963
Merged
alexander-akait merged 1 commit intoMar 10, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
avivkeller
reviewed
Mar 10, 2026
avivkeller
requested changes
Mar 10, 2026
avivkeller
left a comment
avivkeller
left a comment
Member
There was a problem hiding this comment.
Please remove the unrelated file additions
shivxmsharma
force-pushed
the
fix/accessibility-improvements
branch
from
cb55ec9 to
8a097be
Compare
shivxmsharma
force-pushed
the
fix/accessibility-improvements
branch
from
38d11f4 to
c6bd5e6
Compare
shivxmsharma
force-pushed
the
fix/accessibility-improvements
branch
from
c6bd5e6 to
55bb6aa
Compare
alexander-akait
approved these changes
Mar 10, 2026
pranjalisr
pushed a commit
to pranjalisr/webpack.js.org
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves accessibility across three components: Navigation, Footer, and PageNotFound.
Changes made:
aria-label="Main navigation"to the<nav>element in Navigation.jsx so screen readers can identify the primary navigation landmarkaria-labelattributes to the three<section>elements in Footer.jsx ("Quick links", "Home", "Resources and links") for screen reader identificationtarget="_blank"andrel="noopener noreferrer"to all external<a>links in Footer.jsx for consistency (the logo link already had these attributes, but the text links did not)#1a6bacwith SCSS variablegetColor(denim)in PageNotFound.scss and added hover state stylingThese changes address accessibility concerns raised in #7594.
What kind of change does this PR introduce?
fix: accessibility improvements (aria-labels, consistent link attributes, SCSS variable usage)
Did you add tests for your changes?
No tests added — these are accessibility attribute additions and CSS changes that don't affect component logic. Existing tests and snapshots remain passing.
Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No documentation changes needed.
Use of AI
AI (Gemini CLI) was used to help identify accessibility issues in the codebase by scanning component files for missing
aria-labelattributes, inconsistent link attributes, and hardcoded color values. All code changes were written and reviewed manually.