feat(useable): add insertInto support (options.insertInto)#341
Merged
michael-ciniawsky merged 3 commits intowebpack:masterfrom Aug 27, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=========================================
- Coverage 98.43% 97.1% -1.34%
=========================================
Files 4 4
Lines 64 69 +5
Branches 21 23 +2
=========================================
+ Hits 63 67 +4
- Misses 1 2 +1
Continue to review full report at Codecov.
|
michael-ciniawsky
changed the title
insertInto support (options.insertInto)
michael-ciniawsky
approved these changes
Aug 24, 2018
Contributor
michael-ciniawsky
left a comment
michael-ciniawsky
left a comment
There was a problem hiding this comment.
@jasonenglish Thx
alexander-akait
approved these changes
Aug 27, 2018
Member
|
/cc @michael-ciniawsky need release 👍 |
Contributor
|
Released in |
ghost
mentioned this pull request
This was referenced Oct 4, 2019
This was referenced Nov 7, 2019
This was referenced Feb 23, 2020
This was referenced Mar 17, 2020
This was referenced Apr 1, 2020
This was referenced Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature. adds support for insertInto with
useable. fixes #327Did you add tests for your changes?
Yes
If relevant, did you update the README?
I didn't, I figured this feature should be assumed to work with
useableas well. I can add documentation to point it out though.Summary
This feature is needed for injecting styles into the iframe with
useableAFTER the page has loaded. Having the ability to callstyle.use()when the iframe is being setup is crucial. In this scenario we can't use the basic style-loader because specifying the insertInto option will attempt to look for the iframe when it doesn't exist yet.Does this PR introduce a breaking change?
No
Other information
n/a