fix(addStyles): use var instead of const (IE fix)#338
Merged
michael-ciniawsky merged 1 commit intowebpack:masterfrom Aug 8, 2018
Merged
fix(addStyles): use var instead of const (IE fix)#338michael-ciniawsky merged 1 commit intowebpack:masterfrom
var instead of const (IE fix)#338michael-ciniawsky merged 1 commit intowebpack:masterfrom
Conversation
IE10 and below don't support the `const` keyword and are throwing as of v0.22.0. This PR replaces `const` with `var` so everybody's happy.
|
|
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 4 4
Lines 64 64
Branches 21 21
=======================================
Hits 63 63
Misses 1 1Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Aug 8, 2018
michael-ciniawsky
changed the title
var instead of const (IE fix)var instead of const (IE fix)
michael-ciniawsky
approved these changes
Aug 8, 2018
Contributor
michael-ciniawsky
left a comment
michael-ciniawsky
left a comment
There was a problem hiding this comment.
@pleunv I will cut a release asap
Contributor
|
Released in |
Contributor
Author
|
Awesome, thank you! |
This was referenced Aug 8, 2018
ghost
mentioned this pull request
This was referenced Oct 4, 2019
This was referenced Nov 7, 2019
This was referenced Feb 23, 2020
This was referenced Mar 17, 2020
This was referenced Apr 1, 2020
This was referenced Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
v0.22.0 introduced support for webpack nonces, however the code contains a
constkeyword which throws on IE10 and below. This PR replacesconstwithvarso everybody's happy. I've verified this fix in IE10.