fix(addStyles): revert merged loops#236
Conversation
| if(domStyle) { | ||
| domStyle.refs++; | ||
|
|
||
| for(var j = 0; j < domStyle.parts.length && item.parts.length; j++) { |
There was a problem hiding this comment.
Because I followed your guidance #224 (comment) 😛 🚀
There was a problem hiding this comment.
@michael-ciniawsky I'm ashamed, a lot of issues 😞 Btw, we need add tests for this, someone in the future may want to do the same and repeat our my mistake
There was a problem hiding this comment.
totally wayne 😛 , I'm still wondering while this actually makes a difference ¯_(ツ)_/¯ test passed on both ways, but seem to not cover this :D
There was a problem hiding this comment.
@michael-ciniawsky have we minimal test repo? maybe we can determine when this happens and add a tests
There was a problem hiding this comment.
Nope I haven't, only used it locally for a few days and it seemed to work fine + style-loader tests. But I'm not using webpack-hot-middleware or the like
There was a problem hiding this comment.
@michael-ciniawsky let's wait when we have test repo, then add tests and merge and publish. We have big problems with the tests (in many webpack-contrib repos), if we continue to ignore this, it will be very bad
2 participants
Fixes #234, #235