Skip to content

fix: stringify the options.transform request#230

Merged
michael-ciniawsky merged 1 commit intowebpack:masterfrom
liady:patch-1
May 8, 2017
Merged

fix: stringify the options.transform request#230
michael-ciniawsky merged 1 commit intowebpack:masterfrom
liady:patch-1

Conversation

@liady
Copy link
Copy Markdown
Contributor

@liady liady commented May 8, 2017

Stringifies the request for the transform module, to support cross-platform paths. Fixes #229.

What kind of change does this PR introduce?
Bugfix

Did you add tests for your changes?
The current tests cover it

If relevant, did you update the README?
N/A

Summary
Support cross-platform paths for transform module

Solves #229

Does this PR introduce a breaking change?
No.

Other information

Stringifies the request for the transform module, to support cross-platform paths. Fixes webpack#229.
@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented May 8, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liady Thx

@michael-ciniawsky michael-ciniawsky changed the title Stringify the require for css transform module fix: stringify the options.transform request May 8, 2017
@michael-ciniawsky michael-ciniawsky added this to the 0.17.0 milestone May 8, 2017
@michael-ciniawsky michael-ciniawsky modified the milestones: 0.16.2, 0.17.0 May 8, 2017
@michael-ciniawsky michael-ciniawsky merged commit 5888095 into webpack:master May 8, 2017
@michael-ciniawsky michael-ciniawsky modified the milestone: 0.18.2 May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transform breaks when building on windows

3 participants