Upgrade mochiweb dependency#292
Merged
seancribbs merged 5 commits intowebmachine:masterfrom Apr 6, 2018
PhilRunninger:upgrade_mochiweb_dependency
Merged
Upgrade mochiweb dependency#292seancribbs merged 5 commits intowebmachine:masterfrom PhilRunninger:upgrade_mochiweb_dependency
seancribbs merged 5 commits intowebmachine:masterfrom
PhilRunninger:upgrade_mochiweb_dependency
Conversation
added 5 commits
April 5, 2018 17:13
This reverts commit 5546d5a.
Author
|
What's up with the failing tests? They're the same ones mentioned in #286, and they pass locally, BTW. |
Member
|
It looks like an issue with the environment on Travis for that one test. mochiweb is binding to the v6 address, or ibrowse is requesting via the v6. |
Member
|
One possibility is that the test on the failing line is expecting binaries as keys/values in the returned proplist, but they are strings or iodata. There's a fix I want to try locally, if it works I will merge your PR. |
Author
|
Cool. Thanks. |
Member
|
I can't fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291.
erlang:now/0warning.-compile(export_all).statements were removed. One was replaced with an appropriate-export([...]).statement.