This repository was archived by the owner on Sep 7, 2022. It is now read-only.
Open
Conversation
Use case: Accessing properties or attributes directly from the element. Problem: Impossible to access, event via refs, as it reaches the wrapper class only.
Member
|
What's the use-case of this one? |
treshugart
reviewed
May 30, 2018
| return this._elementNode; | ||
| } | ||
| componentDidMount() { | ||
| this._elementNode = ReactDOM.findDOMNode(this); |
Contributor
There was a problem hiding this comment.
Isn't this the same thing as what was happening before?
Author
There was a problem hiding this comment.
After this change it is exposed. The scoped node element is not accessible outside the funciton before this change.
Author
There was a problem hiding this comment.
@treshugart Can this be merged? This helps accessing the native element directly
Contributor
There was a problem hiding this comment.
I guess what I was wondering is that, if you can call comp.getNativeElement(), then you can call findDOMNode(comp) just as easily, no?
Author
|
ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no direct access to the native custom element, even via refs.
The API exposes a way to reach the element itself to retrieve values, attributes, etc.