[Gecko Bug 1824242] part 2: Annotate some SVG WPTs as having some barely-fuzzy (maxDifference=1) pixels.#40802
Merged
Merged
Conversation
…ence=1) pixels. The barely-fuzzy pixels are visually imperceptible; they're just off-by-one in a single color channel, along an antialiased edge of a transformed shape. We have https://bugzilla.mozilla.org/show_bug.cgi?id=1840511 filed to track the underlying behavior here. Since it's imperceptible and isn't what these tests are trying to test for, let's adjust the fuzzy tolerance to avoid a spurious failure. Depends on D182294 Differential Revision: https://phabricator.services.mozilla.com/D182295 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1824242 gecko-commit: 4c8a3d74c0b7570746571e30ebc56b68b05317b3 gecko-reviewers: layout-reviewers, jfkthame
wpt-pr-bot
approved these changes
Jun 29, 2023
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The barely-fuzzy pixels are visually imperceptible; they're just off-by-one in
a single color channel, along an antialiased edge of a transformed shape.
We have https://bugzilla.mozilla.org/show_bug.cgi?id=1840511 filed to track the
underlying behavior here. Since it's imperceptible and isn't what these tests
are trying to test for, let's adjust the fuzzy tolerance to avoid a spurious
failure.
Depends on D182294
Differential Revision: https://phabricator.services.mozilla.com/D182295
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1824242
gecko-commit: 4c8a3d74c0b7570746571e30ebc56b68b05317b3
gecko-reviewers: layout-reviewers, jfkthame