Skip to content

Update remote server logs#10098

Merged
MaggieShan merged 2 commits intomasterfrom
maggs/fix-remote-server-logs
May 4, 2026
Merged

Update remote server logs#10098
MaggieShan merged 2 commits intomasterfrom
maggs/fix-remote-server-logs

Conversation

@MaggieShan
Copy link
Copy Markdown
Contributor

Description

  • Demotes various logs from error to warn to not flood our sentry reporting
  • Updates formatting of logs such that all conversation specific parts are at the end
  • Uses safe_error instead of log::error

Linked Issue

Context: https://warpdev.slack.com/archives/C06MT1NRBFV/p1777920384522969?thread_ts=1777919599.697909&cid=C06MT1NRBFV and https://warpdev.slack.com/archives/C0AMRA82ZKL/p1777920563254069

Testing

No-op

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label May 4, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 4, 2026

@MaggieShan

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@MaggieShan MaggieShan requested a review from kevinyang372 May 4, 2026 22:11
Comment thread app/src/remote_server/server_model.rs Outdated
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates remote-server logging by demoting selected expected failure paths from error to warn, normalizing log formatting, and using safe logging for response variants that may contain sensitive payload details.

Concerns

  • No blocking correctness or security concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@MaggieShan MaggieShan force-pushed the maggs/fix-remote-server-logs branch from 4ed0b4d to 1abf015 Compare May 4, 2026 22:55
@MaggieShan MaggieShan merged commit 16578b1 into master May 4, 2026
24 checks passed
@MaggieShan MaggieShan deleted the maggs/fix-remote-server-logs branch May 4, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants