Update remote server logs#10098
Merged
MaggieShan merged 2 commits intomasterfrom May 4, 2026
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
kevinyang372
approved these changes
May 4, 2026
Contributor
There was a problem hiding this comment.
Overview
This PR updates remote-server logging by demoting selected expected failure paths from error to warn, normalizing log formatting, and using safe logging for response variants that may contain sensitive payload details.
Concerns
- No blocking correctness or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
4ed0b4d to
1abf015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
errortowarnto not flood our sentry reportingsafe_errorinstead oflog::errorLinked Issue
Context: https://warpdev.slack.com/archives/C06MT1NRBFV/p1777920384522969?thread_ts=1777919599.697909&cid=C06MT1NRBFV and https://warpdev.slack.com/archives/C0AMRA82ZKL/p1777920563254069
Testing
No-op
Agent Mode