Fix two small bugs in ext-toc#231
Merged
vsch merged 1 commit intovsch:masterfrom Apr 27, 2018
BlueBoxWare:fixes-in-ext-toc
Merged
Fix two small bugs in ext-toc#231vsch merged 1 commit intovsch:masterfrom BlueBoxWare:fixes-in-ext-toc
vsch merged 1 commit intovsch:masterfrom
BlueBoxWare:fixes-in-ext-toc
Conversation
Contributor
BlueBoxWare
commented
Apr 27, 2018
BlueBoxWare
commented
- One of the constructors of TocOptions was using default values instead of the specified values.
- TocUtils::renderMarkdownToc had loop going in the wrong direction.
Owner
|
@BlueBoxWare, thank you for catching these and making the fixes. |
Owner
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.